Update master-cmsswmaster to CMSSW_10_4_0 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or noiso v2 only so far
Validation/Geometry: CleanUp
Phase2-hgx175 Update documentation of trigger DetId of HGCal and also the mask for trigger type
…ared-macos-upd FWCore/Framework: fix make_shared_noexcept_false template for macOS
DD4hep: Add Trd1 Division
LS-aware access to HcalChannelQuality
Run2-TB40 Update TB geometry for June2018 setup
…gyMode wrt to the original clone of HCAL code
Address comments
Address comments
…hroughout source.
When using PyROOT, the string addresses passed to getByLabel are temporary so we can not hold onto the address even for empty strings.
Tracker DQM HI Quality Test tuning and cleaning for Offline and Online
…uality updated lost plugins definition for SiPixelQuality
…ic_error L1T offline DQM - Fix logic error in L1T muon DQM
Removed from L1 config files parameters which are not longer used
Clean-up Geant4 sensitive detectors 7
DD4hep: Use EventSetup rather then Singleton to store and access vectors
…18-12-09-2300 fixed one bug in GEMCSC algorithm resulting in memory issue. the bug …
…ineProdBase3 Prepare for concurrent IOVs, L1ConfigOnlineProdBase
factor out btagDiscriminators definition for easier modification
Run2-alca147 Add a new class for low lumi runs
[HBHE] Use uniform timeslew parameters
…W_10_4_X_2018-12-07-2300 Simulation of the pixel bad components on the FED channel basis
gpetruc-bot
added
test scheduled (bot)
test started (bot)
and removed
to be tested by bot
test scheduled (bot)
labels
|
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/668236/builds |
gpetruc-bot
reviewed
Jan 21, 2019
There was a problem hiding this comment.
Automatic test report for 668236
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/668236/builds
- outputs at https://cms-nanoaod-integration.web.cern.ch/integration/test_pr_284/
Code integration
Code checks passed for this PR
Tests
- Long test data101X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data80Xhip (3000 events): passed, with differences; dqm plots: all, diff
- Long test data94X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
- Test mc_94Xv2: passed
- Test mc_102X: passed
- Test data_94X: passed
- Test data_101X: passed
Disk size report
| Sample | kb/event | ref kb/event | diff |
|---|---|---|---|
| TTbar MC 94Xv1 | 1.656 | 1.633 | 0.023 ( +1.4% ) |
| TTbar MC 94Xv2 | 1.670 | 1.648 | 0.022 ( +1.3% ) |
| TTbar MC 94X2016 | 1.528 | 1.506 | 0.022 ( +1.4% ) |
| TTbar MC 80X | 1.687 | 1.652 | 0.035 ( +2.1% ) |
| Data 94Xv1 | 0.723 | 0.697 | 0.026 ( +3.7% ) |
| Data 80X | 0.626 | 0.602 | 0.023 ( +3.9% ) |
| Data 80X, Mu Run2016E | 0.612 | 0.599 | 0.013 ( +2.2% ) |
|
Also changes Muon_highPtId as a result of cms-sw#25036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #263 + ports of #267 #273