Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx175 Update documentation of trigger DetId of HGCal and also the mask for trigger type #25395

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 2, 2018

Mostly the doumentation was wrong

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/ForwardDetId

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 2, 2018

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31934/console Started: 2018/12/02 11:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25395/31934/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Dec 2, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 3, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2018

+1

@cmsbuild cmsbuild merged commit c4e05b0 into cms-sw:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants