ECAL - Remove unused parameters from the multifit algorithm

[thomreis]

PR description:

The ECAL uncalibrated rechit multifit algorithm ParameterDescription contained a lot of parameters that are not used anymore for a long time. Those parameters are either loaded from the DB nowadays or they are not needed anymore. This PR removes the unused parameters and cleans up the config files that defined them.
No output changes are expected from these modifications.

PR validation:

Passes the limited matrix tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36935/28270

• This PR adds an extra 1068KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/EcalRecProducers/test/ecalRawDecodingAndMultifit.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699
  • File RecoLocalCalo/EcalRecProducers/test/testEcalRechitProducer_cfg.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducer_cfg.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoEgamma/EgammaHLTProducers (hlt)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please review it and eventually sign? Thanks.
@jainshilpi, @argiro, @Martin-Grunewald, @thomreis, @varuns23, @cericeci, @apsallid, @silviodonato, @lgray, @missirol, @HuguesBrun, @simonepigazzini, @sscruz, @Sam-Harper, @rchatter, @valsdav, @Fedespring, @calderona, @sobhatta, @afiqaize, @wrtabb, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

@thomreis you cannot change directly the configuration in HLTrigger/Configuration, because they are taken from ConfDb.
You need to write a customization function like this https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/customizeHLTforCMSSW.py#L145

[thomreis]

I had a feeling that this was too easy. Is there anything special that I need to do if the module in question is a SwitchProducerCUDA and I need the parameters changed for the cpu option?
Otherwise does this look OK?

# HLT customisation for https://github.com/cms-sw/cmssw/pull/36935                                
def customiseFor36935(process):                                                                   
    """ Customisation to remove parameters from the ParametersetDescription of the                
    EcalUncalibRecHitWorkerMultiFit in PR 36935 (https://github.com/cms-sw/cmssw/pull/36935)      
    """
    for prod in producers_by_type(process, 'EcalUncalibRecHitProducer'):                          
        if hasattr(prod, 'EcalUncalibRecHitWorkerMultiFit'):
            for par in ['ebSpikeThreshold',
                        'ebPulseShape', 
                        'eePulseShape',
                        'chi2ThreshEB_',
                        'chi2ThreshEE_',                                                          
                        'kPoorRecoFlagEB',
                        'kPoorRecoFlagEE',
                        'EcalPulseShapeParameters']:                                              
                if hasattr(prod.algoPSet, par):                                                   
                    delattr(prod.algoPSet, par)                                                   
    return process

[missirol]

Otherwise does this look OK?

@thomreis , looking at the current HLT configs, I would edit your function as follows.

-        if hasattr(prod, 'EcalUncalibRecHitWorkerMultiFit'):
+        if hasattr(prod, 'algoPSet'):

(or maybe you mean something like prod.algo == 'EcalUncalibRecHitWorkerMultiFit' ?)

You can test the customisation function by doing

edmConfigDump HLTrigger/Configuration/test/OnLine_HLT_FULL.py > tmp.py

with and without using the customisation. The diff should be the intended change.

[thomreis]

@missirol you are right I believe it should be if prod.algo == 'EcalUncalibRecHitWorkerMultiFit': since only for that algo I need to changed the algoPSet.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36935/28276

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36935/28276/cms-checkout-topic.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36935/28306

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/EcalRecProducers/test/ecalRawDecodingAndMultifit.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699
  • File RecoLocalCalo/EcalRecProducers/test/testEcalRechitProducer_cfg.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducer_cfg.py modified in PR(s): Add a generic mechanism to specify compute accelerators to use in the configuration #36699

[cmsbuild]

Pull request #36935 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6dacf/22399/summary.html
COMMIT: aae12fa
CMSSW: CMSSW_12_3_X_2022-02-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36935/22399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764435
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3764405
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[jpata]

+reconstruction

• technical code cleanup

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Cleanings are always welcome!