Add back L1CaloGeometry tag to HLT GT #36971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test parameters:
|
|
urgent
|
|
urgent
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36971/28339
|
|
@cmsbuild , please test |
cmsbuild
added
code-checks-approved
tests-started
and removed
tests-pending
code-checks-pending
labels
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: Build BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexLinearizationPointFinders /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexVertexTools /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexVertexPrimitives /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lTrackingToolsTransientTrack /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lDataFormatsPatCandidates collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/libAlignmentMillePedeAlignmentAlgorithmAuto.so] Error 1 Leaving library rule at src/Alignment/MillePedeAlignmentAlgorithm/plugins Entering library rule at Alignment/MillePedeAlignmentAlgorithm >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-15-1100/src/Alignment/MillePedeAlignmentAlgorithm/src/MillePedeFileReader.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-15-1100/src/Alignment/MillePedeAlignmentAlgorithm/src/Mille.cc |
|
@cms-sw/orp-l2 this for sure is not connected to this PR, is this known? |
let me tag also @smuzaffar |
It is related to issues in IB, being discussed: |
|
Running locally the addOnTest I get this error for the And I think the unitTest failing are also related to |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS ---> test runtestTqafTopEventProducers had ERRORS ---> test runtestTqafTopEventSelection had ERRORS ---> test runtestTqafTopHitFit had ERRORS and more ... RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests |
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-983196/22447/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+alca
|
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1
|
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR adds back the
L1CaloGeometry_CRAFT09_hlttag to the HLT GT, as this was causing a crash first reported in #36940 (comment) and later discussed in #36940 (comment) and #36806.Since HLT experts are still in the process of investigating how to modify the producer that consumes this tag, we decided to add it back so it can be included in 12_3_0_pre5 and fix the IBs for now.
GT diff:
Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_v2/123X_dataRun3_HLT_v3
PR validation:
Validated with:
runTheMatrix.py -l 139.004 -j 8 --ibeosBackport:
Already backported in #36948