[ROOTMaster] Updated root to tip of branch master

[iarspider]

No description provided.

[iarspider]

please test

[cmsbuild]

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/rootmaster.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

I also need this version of ROOT for tests I'm doing on RNTuple (as it has the newer interface).

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37361/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37361/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-11-2300/src/FWCore/Framework/interface/LuminosityBlockForOutput.h:21,
                 from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:8,
                 from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h: In instantiation of 'std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = ROOT::Experimental::RNTupleWriter; _Args = {unique_ptr >, unique_ptr >}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t]':
src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:26:45:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h:1065:30: error: 'ROOT::Experimental::RNTupleWriter::RNTupleWriter(std::unique_ptr, std::unique_ptr)' is private within this context
 1065 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:14:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-a6b31fd47d9cb14388e9669f24a910f5/include/ROOT/RNTuple.hxx:462:4: note: declared private here
  462 |    RNTupleWriter(std::unique_ptr model, std::unique_ptr sink);


[smuzaffar]

@iarspider , can you please check if we can update cmssw code to fix https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37361/build-logs/PhysicsTools/NanoAOD/log.html build errors?

[smuzaffar]

ok, hopefully cms-sw/cmssw#43949 should fix the build errors

[smuzaffar]

test parameters:

• pull_request = [ROOT6] RNTuple API change: RNTupleWriter is private cmssw#43949, Fix wildcard imports from ROOT (they are forbidden now) cmssw#43974, Drop PROOF tests (as discussed in #43975) cmssw#43996
• enable = nano

[smuzaffar]

please test for CMSSW_14_1_ROOT6_X

[smuzaffar]

please test for CMSSW_14_1_ROOT6_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37399/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-12-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37399/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test TestRunnerFWCoreTFWLiteSelector had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially removed 29 lines from the logs
• Reco comparison results: 941 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 6623
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3241909
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test for CMSSW_14_1_ROOT6_X

[smuzaffar]

@iarspider , can you please look in to these failing unit tests. Looks like they are all related to the root master change

[smuzaffar]

looks like we need cleanup of https://github.com/search?q=repo%3Acms-sw%2Fcmssw+%22from+ROOT+import+*%22&type=code&p=1

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-13-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37457/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @saumyaphor4252 Update Run3 CSC conditions in 2022, 2023, 2024 realistic MC GTs and offline data GT cmssw#43900
• @mbluj Configuration arguments for version and packing schema of covariance in DeepJetTag producer cmssw#43917
• @CTPPS CTPPS update HLTPPSJetComparisonFilter to use LHCInfoCombined cmssw#43951
• @cms-sw cmssw-elN: Drop -i option to not run in interactive mode #9016

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 4849 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 13274
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3235258
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[smuzaffar]

please test for CMSSW_14_1_ROOT6_X

TPROOF unit test will fail but lets tests the reset of the changes (from ROOT import *)

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37482/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw grpcio: Changes backported from TF 2.15 branch #9015

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test TestRunnerFWCoreTFWLiteSelector had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially removed 109 lines from the logs
• Reco comparison results: 956 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 7651
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3240881
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

please test for CMSSW_14_1_ROOT6_X

[iarspider]

please abort

[iarspider]

please test for CMSSW_14_1_ROOT6_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37525/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @waredjeb Add customize to include Alpaka HCal PF Clustering at HLT cmssw#43971
• @cms-sw eigen: Don't crash on empty tensor contraction #9021

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

Summary:

• You potentially removed 97 lines from the logs
• Reco comparison results: 952 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 7649
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3240883
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

lets get this in root6 IBs . PR to fix the unit tests for from ROOT import * fix can be merged later