Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set c++20 as a default standard #9288

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Jul 9, 2024

We do not have a special branch for CPP20, so this is the only change required.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

test parameters:

  • full_cmssw=true

@iarspider
Copy link
Contributor Author

please test for el9_amd64_gcc13

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_ASAN_X

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@smuzaffar
Copy link
Contributor

please test for slc7_amd64_gcc12

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40297/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_X_2024-07-07-0000/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9288/40297/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40297/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40297/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-particleLevel_fromMiniAod had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40294/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9288/40294/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40294/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40294/git-merge-result

Build

I found compilation error when building:

Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/CUDAKernel/src/HeterogeneousTestCUDAKernel/libHeterogeneousTestCUDAKernel_nv.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/src/HeterogeneousTestROCmDevice/libHeterogeneousTestROCmDevice_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1864: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a] Error 1
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/src/HeterogeneousTestROCmKernel/libHeterogeneousTestROCmKernel_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1864: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a] Error 1


@smuzaffar smuzaffar mentioned this pull request Jul 9, 2024
@smuzaffar
Copy link
Contributor

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40307/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_CLANG_X_2024-07-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9288/40307/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40307/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40307/git-merge-result

Build

I found compilation error when building:

>> Compiling  src/GeneratorInterface/Core/src/pydata.F
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/gfortran -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_CLANG_X_2024-07-07-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_CLANG_X_2024-07-07-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/lhapdf/6.4.0-c15316a5db16cd41771a31339f71f600/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/highfive/2.3.1-805129552f4d5e89d31f03298f4d5685/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-151ffcbc84ac1de5987c8b87687c80dc/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fastjet/3.4.1-4b7559ffa850ea1b7be2d4a6d8178d84/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-5e2ce72ea2977ff21a2344bbb52daf5c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hdf5/1.14.1-e999cb76a07954a3a6bff56dabfaeaee/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc/2.06.10-abf5506ecf31a28643a2f7e59997c7e4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/heppdt/3.04.01-8402bd49f9c576cb017c150b8dc7f491/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pythia6/426-c430ea6f2967f65248af15c71e6c653e/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.30.09-11af6f1423d4c68112d35dd40f8b31df/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-df2a8868ba5d9111864e1a63085d7a4b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc3/3.2.7-33a63b9847691e77f4e5de974aca5a50/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.15-c877ab57fa7b04ce290093588c6c5717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/openmpi/4.1.6-42dff792327bcf1b8ab42ad65aae8fe3/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -fno-second-underscore -Wunused -Wuninitialized -O3 -cpp -std=legacy -fno-second-underscore -Wunused -Wuninitialized -O3 -cpp -std=legacy -O3 -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/pydata.F.d src/GeneratorInterface/Core/src/pydata.F -o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/pydata.F.o
>> Building shared library tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/libGeneratorInterfaceCore.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/llvm/18.1.6-2492d8c1d12649e8f2c771154cd85362/bin/clang++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-unknown-warning-option -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -Wno-tautological-type-limit-compare -Wno-vla-cxx-extension -fsized-deallocation --gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -shared -Wl,-E      -Wl,-z,defs     tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/BaseHadronizer.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/BaseHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/EmbeddingHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/FortranCallback.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/FortranInstance.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/GenericDauHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/HepMCFilterDriver.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/ParameterCollector.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/PartonShowerBsHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/PartonShowerCsHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/PythiaHepMCFilterGammaGamma.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/TaggedProtonHepMCFilter.cc.o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/pydata.F.o -o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/libGeneratorInterfaceCore.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CLANG_X_2024-07-07-2300/biglib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CLANG_X_2024-07-07-2300/lib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CLANG_X_2024-07-07-2300/external/el8_amd64_gcc12/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CLANG_X_2024-07-07-2300/static/el8_amd64_gcc12 -lGeneratorInterfaceLHEInterface -lFWCoreFramework -lUtilitiesStorageFactory -lFWCoreCommon -lFWCoreServiceRegistry -lSimDataFormatsGeneratorProducts -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lFWCoreUtilities -lFWCoreVersion -lUtilitiesXerces -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lThread -lLHAPDF -lMathCore -lRIO -lboost_program_options -lpythia6 -lpythia6_dummy -lpythia6_pdfdummy -lCore -lboost_thread -lboost_date_time -lCLHEP -lHepMCfio -lHepMC -lpcre -lbz2 -lfastjetplugins -lfastjettools -lsiscone -lsiscone_spherical -lfastjet -lgsl -lhdf5 -lhdf5_hl -lHepPDT -lHepPID -luuid -ltbb -lxerces-c -llzma -lz -lfmt -lgfortran -lm -lHepMC3 -lHepMC3search -lcms-md5 -lopenblas -lmpi -lmpi_cxx -lssl -lcrypto -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lGeneratorInterfaceLHEInterface: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/src/GeneratorInterfaceCore/libGeneratorInterfaceCore.so] Error 1
Leaving library rule at GeneratorInterface/Core
>> Compiling  src/GeneratorInterface/Core/bin/externalGenerator.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/llvm/18.1.6-2492d8c1d12649e8f2c771154cd85362/bin/clang++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_CLANG_X_2024-07-07-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_CLANG_X_2024-07-07-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-151ffcbc84ac1de5987c8b87687c80dc/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc/2.06.10-abf5506ecf31a28643a2f7e59997c7e4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/python3/3.9.14-c10287ae9cadff55334e60003302c349/include/python3.9 -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.30.09-11af6f1423d4c68112d35dd40f8b31df/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-df2a8868ba5d9111864e1a63085d7a4b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc3/3.2.7-33a63b9847691e77f4e5de974aca5a50/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/py3-pybind11/2.12.0-857784db2d3fea20ed3006c707e589a0/lib/python3.9/site-packages/pybind11/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-unknown-warning-option -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -Wno-tautological-type-limit-compare -Wno-vla-cxx-extension -fsized-deallocation --gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/bin/cmsExternalGenerator/externalGenerator.cc.d src/GeneratorInterface/Core/bin/externalGenerator.cc -o tmp/el8_amd64_gcc12/src/GeneratorInterface/Core/bin/cmsExternalGenerator/externalGenerator.cc.o
>> Building binary cmsExternalGenerator


@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40296/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_X_2024-07-07-0000/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9288/40296/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40296/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40296/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestHeterogeneousCoreSonicTritonProducerCPU had ERRORS
---> test DRNTest had ERRORS
---> test testFWCoreConcurrencyCatch2 had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 2207 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 58614 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 342465
  • DQMHistoTests: Total nulls: 216
  • DQMHistoTests: Total successes: 2904092
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6.625 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.381 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.035 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 23234.0,... ): 0.817 KiB MTD/Vertices
  • DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.064 KiB SiStrip/MechanicalView
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 15 / 45 workflows

@smuzaffar
Copy link
Contributor

please test for el9_amd64_gcc13

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40334/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_ASAN_X_2024-07-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9288/40334/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40334/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40334/git-merge-result

Unit Tests

I found 14 errors in the following unit tests:

---> test SubmitPVsplit had ERRORS
---> test GeometryDOMCount had ERRORS
---> test TestDQMServicesDemo had ERRORS
and more ...

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#45428 for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40336/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_X_2024-07-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9288/40336/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40336/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40336/git-merge-result

Build

I found compilation error when building:

Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/CUDAKernel/src/HeterogeneousTestCUDAKernel/libHeterogeneousTestCUDAKernel_nv.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/src/HeterogeneousTestROCmDevice/libHeterogeneousTestROCmDevice_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1864: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmDevice/test/testRocmDeviceAddition/libtestRocmDeviceAddition_rocm.a] Error 1
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/src/HeterogeneousTestROCmKernel/libHeterogeneousTestROCmKernel_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1864: tmp/el9_amd64_gcc13/src/HeterogeneousTest/ROCmKernel/test/testRocmDeviceAdditionKernel/libtestRocmDeviceAdditionKernel_rocm.a] Error 1


@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e2b3/40341/summary.html
COMMIT: 89d71ea
CMSSW: CMSSW_14_1_CLANG_X_2024-07-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9288/40341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16966 lines to the logs
  • Reco comparison results: 33352 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 39468
  • DQMHistoTests: Total nulls: 171
  • DQMHistoTests: Total successes: 3305435
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.02 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.027 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@smuzaffar
Copy link
Contributor

+externals

this looks good to go in. We will need cms-sw/cmssw#45428 for clang build

@smuzaffar smuzaffar merged commit 74a7450 into IB/CMSSW_14_1_X/master Jul 12, 2024
26 of 30 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#45428

@smuzaffar
Copy link
Contributor

please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants