Excess number of "tbb" info message being generated

[cvuosalo]

Running cmsRun Geometry/DTGeometryBuilder/test/python/validateDTGeometry_cfg.py generates about 270,000 INFO messages:

%MSG-i Root_Information:  DTGeometryValidate:valid@ctor TThreadExecutor::ParallelFor() 22-Feb-2021 23:50:26 CET pre-events
tbb::global_control is limiting the number of parallel workers. Proceeding with 1 threads this time

The message is desired and appropriate, but not so many of them. It is probably generated by ROOT.

[cmsbuild]

A new Issue was created by @cvuosalo Carl Vuosalo.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

(some history for reference #32947, #32782, cms-sw/cmsdist#6612, cms-sw/cmsdist#6570)

[cvuosalo]

@ianna @civanch FYI

[mrodozov]

I remember we discussed we can suggest to ROOT to add an option to silence this, but did we discussed silencing it on our own and if not why not :) ?

[davidlange6]

Its better that we upstream patches to root…

…

On Feb 25, 2021, at 6:16 PM, Mircho Rodozov ***@***.***> wrote: I remember we discussed we can suggest to ROOT to add an option to silence this, but did we discussed silencing it on our own and if not why not :) ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[makortel]

I started to also think if we actually should give an argument to

cmssw/FWCore/Services/plugins/InitRootHandlers.cc

Line 833 in 5d91b01

ROOT::EnableImplicitMT();

given comments in
https://github.com/root-project/root/blob/4f5dbbeaa69738ae03094b1cce60e8722e1f8a3d/core/base/src/TROOT.cxx#L501-L524

Then the if condition in ROOT would automatically prevent these messages in the first place.

@Dr15Jones what do you think?

[oshadura]

@mrodozov, I saw @davidlange6 is suggesting upstream patches to root, can I take a look please on patches?

[eguiraud]

Hi, Enrico from the ROOT team. I might be missing some larger context but in principle I agree with @makortel 's suggestion: if you use tbb::global_control to limit TBB's concurrency level to 1, you should also call ROOT::EnableImplicitMT(1), and that should get rid of the warnings.

[makortel]

Hi, Enrico from the ROOT team. I might be missing some larger context but in principle I agree with @makortel 's suggestion: if you use tbb::global_control to limit TBB's concurrency level to 1, you should also call ROOT::EnableImplicitMT(1), and that should get rid of the warnings.

This is now done in #33038

[makortel]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.