-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient #10472
Conversation
…GenericClient This allows to use the cumulative histograms in efficiency calculations (e.g. for "efficiency as a function of cut value" plots).
…and both with weighted by pT
… is not limited to events with correctly identified PV
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient It involves the following packages: DQMServices/ClientConfig @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
9a26bcd
to
8e7724e
Compare
ping |
please test |
The tests are being triggered in jenkins. |
ping |
+1 |
Thanks :) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient
This PR adds the following histograms to MultiTrackValidator (only to the
Tracks
instance): efficiency and fake/duplicate/pileup rates vs.All of these are filled only for events where the reco PV (
offlinePrimaryVertices[0]
) is matched to the simulated PV (of the signal event). These plots help to understand and monitor the association of tracks to the PV.In order to make the "efficiency/rates vs. cut on dz(PV)" plots, I moved the normalization and cumulation in DQMGenericClient to be done before efficiency calculation. This change has no effect on the current users of the cumulation feature.
Tested in CMSSW_7_6_X_2015-07-25-2300, no changes expected in existing histograms.
@rovere @VinInn