Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient #10472

Merged
merged 6 commits into from
Aug 10, 2015

Conversation

makortel
Copy link
Contributor

This PR adds the following histograms to MultiTrackValidator (only to the Tracks instance): efficiency and fake/duplicate/pileup rates vs.

  • dxy and dz wrt. primary vertex
  • cut on dz wrt. primary vertex in couple of flavours
    • cut on dz(PV)
    • cut on dz(PV)/zError
    • cut on dz(PV) weighted by TP/track pT
    • cut on dz(PV)/zError weighted by TP/track pT

All of these are filled only for events where the reco PV (offlinePrimaryVertices[0]) is matched to the simulated PV (of the signal event). These plots help to understand and monitor the association of tracks to the PV.

In order to make the "efficiency/rates vs. cut on dz(PV)" plots, I moved the normalization and cumulation in DQMGenericClient to be done before efficiency calculation. This change has no effect on the current users of the cumulation feature.

Tested in CMSSW_7_6_X_2015-07-25-2300, no changes expected in existing histograms.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient

It involves the following packages:

DQMServices/ClientConfig
Validation/RecoTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@barvic, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@makortel
Copy link
Contributor Author

makortel commented Aug 4, 2015

ping

@deguio
Copy link
Contributor

deguio commented Aug 6, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@makortel
Copy link
Contributor Author

ping

@deguio
Copy link
Contributor

deguio commented Aug 10, 2015

+1

@makortel
Copy link
Contributor Author

Thanks :)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 10, 2015
Add efficiency and fake rate vs. dxy/dz wrt PV to MultiTrackValidator, and make normalization+cumulative histograms before efficiency in DQMGenericClient
@cmsbuild cmsbuild merged commit 11b2f0d into cms-sw:CMSSW_7_6_X Aug 10, 2015
@makortel makortel deleted the trackingValidationTrackDz branch October 20, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants