Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSCHaloData kept in AOD #10656

Merged
merged 1 commit into from
Aug 12, 2015
Merged

CSCHaloData kept in AOD #10656

merged 1 commit into from
Aug 12, 2015

Conversation

lathomas
Copy link
Contributor

Request to keep the CSCHaloData class content in AOD.
Size of the class: 128 bytes (62 compressed)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for CMSSW_7_5_X.

CSCHaloData kept in AOD

It involves the following packages:

RecoMET/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10656 7388fa1

Adding CSC halo data to AOD. There should be no changes to monitored quantities. #10652 and #10655 are the 74X and 75Xversions of this PR, though #10652 also includes a bug fix that was already added to 75X and 76X. They have both been already approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-10-1100 show no significant differences, as expected. The addition of the CSC halo data to AOD was verified for workflow 25202.0 for PR #10652.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 12, 2015
@cmsbuild cmsbuild merged commit 27d545f into cms-sw:CMSSW_7_5_X Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants