Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 MHT and forward Jet fixes (75X backport 11676) #11677

Merged

Conversation

harmonicoscillator
Copy link
Contributor

75X backport of #11676
This PR depends on #11373 (and includes those commits since they are not merged yet).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

L1 MHT and forward Jet fixes (75X backport 11676)

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8981/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 6586f9b
When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11677/8981/summary.html

@mulhearn
Copy link
Contributor

mulhearn commented Nov 5, 2015

please test

@mulhearn
Copy link
Contributor

mulhearn commented Nov 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9483/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

-1
@richard-cms This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11677/9483/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@richard-cms @mulhearn - this needs a rebase

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9619/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@harmonicoscillator
Copy link
Contributor Author

@davidlange6 Sorry I haven't had time to rebase this - does it still actually need a rebase, or are the relval errors transient?

@davidlange6
Copy link
Contributor

@richard-cms - github seems happy now.. not sure why something changed

davidlange6 added a commit that referenced this pull request Nov 10, 2015
L1 MHT and forward Jet fixes (75X backport 11676)
@davidlange6 davidlange6 merged commit 6dbf063 into cms-sw:CMSSW_7_5_X Nov 10, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants