Update hcal strip 80 x #13117
Update hcal strip 80 x #13117
Conversation
|
A new Pull Request was created by @aminnj (Nick Amin) for CMSSW_8_0_X. It involves the following packages: DataFormats/METReco @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@aminnj |
| std::vector<const CaloTower*> sortedCaloTowers; | ||
| for(CaloTowerCollection::const_iterator tower = TheCaloTowers->begin(); tower != TheCaloTowers->end(); tower++) { | ||
| if(abs(tower->ieta()) <= maxAbsIEta && tower->numProblematicHcalCells() > 0) | ||
| sortedCaloTowers.push_back(&(*tower)); | ||
| if(abs(tower->ieta()) > maxAbsIEta) continue; |
There was a problem hiding this comment.
std::abs (to more convincingly see it's the C++ STL abs, not the C abs)
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
@cmsbuild please test |
|
+1
|
|
(plots were updated in #13117 (comment)) |
| @@ -7,6 +7,7 @@ | |||
| [date]: October 15, 2009 | |||
| */ | |||
| #include <vector> | |||
| #include <map> | |||
There was a problem hiding this comment.
this include should be in the cc file (though see next comment)
@aminnj
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: a468287 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
+1
|
The Hcal Strip beam halo filter from #10934 has been supplemented with two extra cuts to slightly increase halo rejection efficiency while dramatically lowering fake rate (O(10^-4)) in MC signal samples with large amounts of hadronic activity.