Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New MillePede production system (Backport of #13957) #13958

Merged
merged 7 commits into from
Apr 12, 2016
Merged

New MillePede production system (Backport of #13957) #13958

merged 7 commits into from
Apr 12, 2016

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Apr 6, 2016

Has been presented in https://indico.cern.ch/event/512679/session/0/contribution/8/attachments/1252066/1849483/Alignment-UpdateMPS_CMS-TkAl_20160406.pdf

Summary of changes:

  • Partial rewrite of the Perl scripts in Python -> Easier to maintain in the future
  • Update the unversioned scripts and put them under version control
  • Use a unified config and put it under version control
    • Makes use of the unified track selection and refitting sequence
  • General streamlining
    • Replaced deprecated modules in the configuration
    • Replaced some ancient (unsupported) commands

Backport of #13957

muffinfan and others added 7 commits April 6, 2016 14:24
@muffinfan @gregor-mittag
New MillePede production system.
3506dfd 
 - less error-prone
 - unified track selection and refitting sequence
 - partial rewrite in python of old perl scripts
 - old production system left operational for the time being
@gregor-mittag
Replace usage of condDBv1 tools with condDBv2 in pede script template.
83bc3f2
@gregor-mittag
Replace aligncond_split_iov in pede script with script using condDBv2…
b28e9d3 
… tools.
@gregor-mittag
Remove CASTOR prestage block in MillePede script creation process.
e4c813a
@gregor-mittag
Fixed an old bug in 'mps_setupm.pl'.
46e3a59 
 - when duplicating the pede job folder before the mille jobs are done the
   resulting pede job script is wrong
   -> this is not always intended and an erroneous check meant to prevent this
      is fixed by this commit
@gregor-mittag
Adaptions to the unified track selection sequence.
4f59899 
 - put into actual use for the first time
@gregor-mittag
Make the unified track selection applicable to 'generalTracks'.
8bcbe3e 
 - treat them like MinBias tracks
 - replaced the check for string identity with checks for string equality
   -> not sure if needed here, but can be different in general and leads to
      strange errors in such cases

 TODOS:
  - do not copy monitoring files for the individual jobs to afs, but only to eos
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Apr 6, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Apr 6, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12206/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

+1
Tested at: 8bcbe3e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13958/12206/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4283c59
13c3790
525fc74
4e91235
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13958/12206/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13958/12206/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13958/12206/summary.html

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 640507c into cms-sw:CMSSW_8_0_X Apr 12, 2016
@ghellwig ghellwig deleted the new-MillePede-production-system_80X branch April 18, 2016 09:46
@ghellwig ghellwig restored the new-MillePede-production-system_80X branch April 18, 2016 12:01
@ghellwig ghellwig deleted the new-MillePede-production-system_80X branch April 28, 2016 10:22
@ghellwig ghellwig restored the new-MillePede-production-system_80X branch April 28, 2016 10:22
@ghellwig ghellwig deleted the new-MillePede-production-system_80X branch July 14, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
6 participants
@ghellwig @cmsbuild @mmusich @davidlange6 @muffinfan @gregor-mittag