Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62X no tracking particles #1528

Merged
merged 54 commits into from
Nov 26, 2013
Merged

Conversation

fabiocos
Copy link
Contributor

Back-port from 70X MixingModule scenarios cleaning and set no Tracking Particles as default

gregor-mittag and others added 30 commits October 10, 2013 12:57
…t it can be run in PCL in the cosmcics scenario
…o in DataProcessing to allow for generation of the configuration of Tier0 for PCL
…st the Tier0 configuration of the AlCaHarvesting step of PCL out of ConfigDP
…the Tier0 Express configuration out of ConfigDP
Add missing event content CommonEventContent to FEVTSIM.
Import missing Winter13 BTag performance DB from CVS
adding patch for average X in Z decays - patch to replace pull cms-sw#1410
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_6_2_X.

62X no tracking particles

It involves the following packages:

SimGeneral/MixingModule
Configuration/PyReleaseValidation
Configuration/Applications
Configuration/StandardSequences

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @giamman, @fabiocos can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlt you are the release manager for this.

If any of the signals cmsRun catches (SIGINT and SIGUSR2) are caught, cmsRun now returns a non zero value. This was requested by data ops.
Backported from CMSSW_7_0_X.

Conflicts:
	FWCore/Framework/bin/cmsRun.cpp
@fabiocos
Copy link
Contributor Author

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Nov 22, 2013

+1

@ghost ghost assigned davidlt Nov 24, 2013
@davidlt
Copy link
Contributor

davidlt commented Nov 24, 2013

Python error:

Compiling src/Configuration/Applications/python/ConfigBuilder.py ...
Sorry: IndentationError: ('unindent does not match any outer indentation level', ('src/Configuration/Applications/python/ConfigBuilder.py', 1355, 39, "         if sequence == 'pdigi_valid':\n"))
gmake[1]: *** [CompilePython] Error 1

@fabiocos
Copy link
Contributor Author

indentation problem in python fixed, it manages to get wf 25 passing the test

@cmsbuild
Copy link
Contributor

Pull request #1528 was updated. @vciulli, @perrotta, @civanch, @Dr15Jones, @vlimant, @demattia, @fwyzard, @franzoni, @mdhildreth, @ktf, @Martin-Grunewald, @cmsbuild, @thspeer, @rcastello, @giamman, @slava77, @vadler, @fabiocos, @nclopezo can you please check and sign again.

@perrotta
Copy link
Contributor

-1

runTheMatrix.py -l 8.0
fails at step 2 ( Step: DIGI Spec: ['pdigi_valid'] )

@perrotta
Copy link
Contributor

Another error which has to be fixed, spotted by the HLT specific tests and not by the short matrix:

----- Begin Fatal Exception 25-Nov-2013 16:21:07 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 2 event: 101
[1] Running path 'prevalidation_step'
[2] Calling event method for module SimHitTPAssociationProducer/'simHitTPAssocProducer'
Exception Message:
Principal::getByLabel: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: mix
Looking for productInstanceName: MergedTrackTruth

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

To reproduce (e.g.):

In CMSSW_6_2_X_2013-11-20-0200:
cd src
git cms-addpkg HLTrigger/Configuration
git cms-merge-topic 1528
git cms-checkdeps -a
scram build -j 4

(Go for a chat and a coffee....)

cd HLTrigger/Configuration/test/
./cmsDriver.sh # this makes a bunch of cfg files ready for cmsRun.

Then execute:
cmsRun RelVal_DigiL1RawHLT_GRun_STARTUP.py >& RelVal_DigiL1RawHLT_GRun_STARTUP.log
The above takes a GEN-SIM file from /store and runs HLT, writes an output file w/out problems!

The exception occurs in the second step which reads in the just created output file:
cmsRun RelVal_RECO_GRun_STARTUP.py >& RelVal_RECO_GRun_STARTUP.log

@Martin-Grunewald
Copy link
Contributor

This PR is included in and superseeded by #1589 which adds the required HLT changes (same as already in 70X).

@vadler
Copy link

vadler commented Nov 25, 2013

@Martin-Grunewald : Is this to be ignored then and can be closed?

@vadler
Copy link

vadler commented Nov 25, 2013

+1
since AT is only touched by merges of already approved pull requests.

@davidlt davidlt merged commit a4c3010 into cms-sw:CMSSW_6_2_X Nov 26, 2013
@fabiocos fabiocos deleted the 62X-noTrackingParticles branch December 4, 2013 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment