island photons for XeXe collision era + HI pp reference run era and relval wf (94X) #21069

ttrk · 2017-10-30T06:10:35Z

fixes the pp_on_XeXe_2017 era to run island photons and add them into event content
original PR for pp_on_XeXe_2017 era : #20749
adds "Run2_2017_ppRef" era to run customized reco for HI pp reference run
adds a corresponding relval wf (149)
runs and stores photonIsolationHIProducer objects using the era
backport of #20929 and #21122

…me" ambiguity with the modules under RecoEcal/EgammaClusterProducers/

…fic islandSuperClusters modules

…andSuperClusters modules

…ers modules

…perClusters modules" as suggested here cms-sw#20929 (comment)

…correctedEndcapSuperClustersWithPreshower required by this change cms-sw@7d38e46

specifically revert all commits starting from here cms-sw@7d38e46 This revert is suggested here cms-sw#20929 (comment)

…fiers to the original definitions in RecoEcal/EgammaClusterProducers as suggested here cms-sw#20929 (comment) and here cms-sw#20929 (comment)

cmsbuild · 2017-10-30T06:10:58Z

A new Pull Request was created by @ttrk (Kaya Tatar) for CMSSW_9_4_X.

It involves the following packages:

RecoEcal/Configuration
RecoEcal/EgammaClusterProducers
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers
RecoHI/HiEgammaAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @varuns23, @rovere, @argiro, @yenjie, @jazzitup, @kurtejung, @lgray, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-10-30T08:39:15Z

please test

cmsbuild · 2017-10-30T08:39:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24039/console Started: 2017/10/30 09:42

cmsbuild · 2017-10-30T10:16:12Z

+1
Tested at: b3b63da
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24039/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24039/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24039/git-merge-result

cmsbuild · 2017-10-30T10:16:14Z

Comparison job queued.

cmsbuild · 2017-10-30T11:54:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24039/summary.html

There are some workflows for which there are errors in the baseline:
10024.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2804141
DQMHistoTests: Total failures: 108
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2803862
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

perrotta · 2017-10-30T13:15:20Z

+1

Identical to island photons for XeXe collision era #20929, submitted to the master (by now 10_X)

perrotta · 2017-11-07T22:40:11Z

abort test

cmsbuild · 2017-11-07T22:40:29Z

Jenkins tests are aborted.

perrotta · 2017-11-07T22:45:27Z

I see that the same output shows up also in the comparison summaries of other pull requests, thus confirming that it is not related to this one: there is no reason to re-launch the tests then.

However, since I reset the flags of the tests, I will re-run them to turn them to green once again...

perrotta · 2017-11-07T22:45:34Z

please test

cmsbuild · 2017-11-07T22:45:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24256/console Started: 2017/11/08 00:37

perrotta · 2017-11-07T22:47:05Z

+1

(Since the tests already succeeded once, I can sign anyhow)
Configuration changes are driver by the corresponding era, and coincide with the ones already merged in the master

cmsbuild · 2017-11-08T01:49:33Z

+1
Tested at: f4bce3a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24256/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24256/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24256/git-merge-result

cmsbuild · 2017-11-08T01:49:35Z

Comparison job queued.

cmsbuild · 2017-11-08T05:19:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21069/24256/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2838442
DQMHistoTests: Total failures: 100
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2838171
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
Checked 107 log files, 8 edm output root files, 26 DQM output files

davidlange6 · 2017-11-09T11:23:46Z

merge

Kaya Tatar added 10 commits October 13, 2017 05:23

fix the pp_on_XeXe_2017 era to run and store island photons

f03d421

use standard PhotonProducer for island photons

05ae264

rename HI-specific islandSuperClusters modules to remove the "same na…

7d38e46

…me" ambiguity with the modules under RecoEcal/EgammaClusterProducers/

propagate the changes for pp_on_XeXe_2017 era after renaming HI-speci…

5e3dedf

…fic islandSuperClusters modules

propagate the changes to ValidationHeavyIons renaming HI-specific isl…

3c86e0e

…andSuperClusters modules

add temporary customization for renaming HI-specific islandSuperClust…

0200b59

…ers modules

revert "add temporary customization for renaming HI-specific islandSu…

efcf767

…perClusters modules" as suggested here cms-sw#20929 (comment)

propagate the renaming of HI-specific islandSuperClusters modules to …

3335c02

…correctedEndcapSuperClustersWithPreshower required by this change cms-sw@7d38e46

revert "rename HI-specific islandSuperClusters modules"

0af09c4

specifically revert all commits starting from here cms-sw@7d38e46 This revert is suggested here cms-sw#20929 (comment)

add island clustering to pp_on_XeXe_2017 era by applying the era modi…

b3b63da

…fiers to the original definitions in RecoEcal/EgammaClusterProducers as suggested here cms-sw#20929 (comment) and here cms-sw#20929 (comment)

cmsbuild added this to the CMSSW_9_4_X milestone Oct 30, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 30, 2017

ttrk mentioned this pull request Oct 30, 2017

island photons for XeXe collision era #20929

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2017

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-available tests-approved tests-pending labels Nov 7, 2017

cmsbuild added tests-pending and removed tests-started labels Nov 7, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 7, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 7, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 8, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 8, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 9, 2017

cmsbuild merged commit 0900057 into cms-sw:CMSSW_9_4_X Nov 9, 2017

ttrk mentioned this pull request Nov 15, 2017

keep islandPhoton related collections via HI eras (94X) #21311

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

island photons for XeXe collision era + HI pp reference run era and relval wf (94X) #21069

island photons for XeXe collision era + HI pp reference run era and relval wf (94X) #21069

ttrk commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017 •

edited

Loading

perrotta commented Nov 7, 2017

cmsbuild commented Nov 8, 2017

cmsbuild commented Nov 8, 2017

cmsbuild commented Nov 8, 2017

davidlange6 commented Nov 9, 2017

island photons for XeXe collision era + HI pp reference run era and relval wf (94X) #21069

island photons for XeXe collision era + HI pp reference run era and relval wf (94X) #21069

Conversation

ttrk commented Oct 30, 2017 • edited Loading

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017 • edited Loading

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017 • edited Loading

perrotta commented Nov 7, 2017

cmsbuild commented Nov 8, 2017

cmsbuild commented Nov 8, 2017

cmsbuild commented Nov 8, 2017

davidlange6 commented Nov 9, 2017

ttrk commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Nov 7, 2017 •

edited

Loading