Fix Premixing for Phase 1 Pixel Detector

[mdhildreth]

Stop adding ADC=0 digis to data stream.

[cmsbuild]

A new Pull Request was created by @mdhildreth for CMSSW_9_4_X.

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24196/console Started: 2017/11/06 09:19

[cmsbuild]

+1
Tested at: 8a4b7c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21177/24196/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21177/24196/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21177/24196/git-merge-result

[cmsbuild]

Comparison job queued.

[makortel]

I'd be interested to learn more on what exactly was the problem and how this PR fixes it.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21177/24196/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2838442
• DQMHistoTests: Total failures: 111
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2838160
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge