Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune cp5 down snippets93x #24575

Closed
wants to merge 426 commits into from
Closed

Conversation

efeyazgan
Copy link
Contributor

backport of #24527

nsmith- and others added 30 commits October 27, 2017 13:14
Also allows someone to use slimmedEgammaFromMultiCl_cff separately
Electron cluster is the one exception, as it needs some PAT code changes
to allow clusters where the seed is in ForwardSubdetector
Fill time and uncertainties for slimmed primary vertices (93X)
Also drop pt cut back to 10 because we don't have a billion fake
electrons now.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24575/6468

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24575/6468/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24575/6468/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@kpedro88
Copy link
Contributor

wrong branch (twice?)

@efeyazgan
Copy link
Contributor Author

yes, wrong twice! I'll fix it soon.

@Martin-Grunewald
Copy link
Contributor

-1
wrong release?

@efeyazgan
Copy link
Contributor Author

yes, wrong release (should have been 93X)

@efeyazgan efeyazgan closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment