Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfix in HCAL peds+ped.widths DB objects names (HcalTextCalibrations input) #24779

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

abdoulline
Copy link

Discrepancy in DB object names of "effective" (i) pedestals and (ii) ped.widths
didn't allow for reading these conditions from txt files. Now fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@abdoulline abdoulline changed the title Small bugfix in HCAL peds+ped.widths DB objects names (txt input) Small bugfix in HCAL peds+ped.widths DB objects names (HcalTextCalibrations input) Oct 2, 2018
@pohsun
Copy link

pohsun commented Oct 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30901/console Started: 2018/10/05 17:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24779/30901/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162780
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@pohsun
Copy link

pohsun commented Oct 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 72d1378 into cms-sw:master Oct 11, 2018
@abdoulline abdoulline deleted the fix_txt_effective_peds_103X branch May 13, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants