DD4Hep: DDTrackerRingAlgo remove double definition and spacing

[vargasa]

PR description:

No major changes. Addresses @cvuosalo review comment and some code cosmetics.

PR validation:

cmsRun Geometry/MTDGeometryBuilder/test/python/testMTDGeometry.py
cmsShow -c simGeo.fwc cmsDD4HepGeom.root --tgeo-name=MTD

if this PR is a backport please specify the original PR:

No backport

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26472/9309

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

Geometry/MTDGeometryBuilder
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @ebrondol, @venturia, @VinInn, @ghugo83 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34244/console Started: 2019/04/17 13:51

[cmsbuild]

+1
Tested at: bb95e10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26472/34244/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26472/34244/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)