DD4hep: DDTIDAxialCable Algorithm

[ianna]

PR description:

Port of a DDTIDAxialCable algorithm to DD4hep

@vargasa - FYI, the numbers in xml are kind of random. Please, feel free to modify them.

PR validation:

cmsRun DetectorDescription/DDCMS/test/python/testDDTIDAxialCableAlgorithm.py

if this PR is a backport please specify the original PR:

no backport is needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9545

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9545/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9545/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9545/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9545/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[ianna]

@smuzaffar - I think anything after a { should be indented to avoid this:

}
} // namespace

[ianna]

@smuzaffar - I don't think this formatting is particularly useful:

-    LogVerbatim("TIDGeom") << "DDTIDAxialCableAlgo test: "
-                        << solid.name()
-                        << " Polycone made of "<< matIn
-                        << " from " << convertRadToDeg(-0.5*width)
-                        << " to " << convertRadToDeg(0.5*width)
-                        << " and with "  << pconZ.size() << " sections ";
-
+    LogVerbatim("TIDGeom") << "DDTIDAxialCableAlgo test: " << solid.name() << " Polycone made of " << matIn << " from "
+                           << convertRadToDeg(-0.5 * width) << " to " << convertRadToDeg(0.5 * width) << " and with "
+                           << pconZ.size() << " sections ";

as you can see, the lines are too long.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9550

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9550/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9550/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[ianna]

@smuzaffar - will the code checks be re-triggered? There was a commit just after it started.

[smuzaffar]

look like bot thinks that it has already processed your last commit. I can re-trigger it but you can do it to by adding code-checks comment

[smuzaffar]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26604/9609

• This PR adds an extra 32KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34521/console Started: 2019/05/06 14:41

[cmsbuild]

Pull request #26604 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[cmsbuild]

+1
Tested at: 9f40f38
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26604/34521/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2fad8ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26604/34521/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26604/34521/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26604/34521/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1