Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DT Online-DQM to work with slice test data #26651

Merged
merged 2 commits into from
May 9, 2019

Conversation

battibass
Copy link

PR description:

This PR includes recent changes to the DTDigiTask module alongside with the necessary DQM configuration file changes to prepare the DT DQM to process data from the DT slice test.
Though the DQM monitoring for the DT slice test will initially be performed only exploiting a "private" DT-DQM deployment @ P5, a PR is anyhow prepared to keep the DQM code in the release as much "up to date" as possible.

The PR only affects Online-DQM code, and the updates are not supposed to change the behaviour of the DT-DQM, if it is run on data other than the slice test one. So no changes are expected.

PR validation:

The PR has been tested within a private deployment of the DT Online-DQM.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26651/9612

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2019

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

DQM/DTMonitorModule

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/43/console Started: 2019/05/07 11:34

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fc0e2/43/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

+1

@cmsbuild cmsbuild merged commit b91bd57 into cms-sw:master May 9, 2019
@battibass battibass deleted the dtDigiTask_SliceTest_v106X branch April 5, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants