Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HeaderCheck][Sim] Remove unused header in Mixing/Base #26698

Merged
merged 1 commit into from
May 8, 2019

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented May 8, 2019

  • Remove the file. After "fixing" it it kept breaking check-headers check, and it's also unused

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

mrodozov commented May 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26698/9678

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/83/console Started: 2019/05/08 16:21

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Mixing/Base

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0a47c/83/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented May 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 8, 2019

+1

@cmsbuild cmsbuild merged commit 26acd4f into cms-sw:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants