-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: dump HGCal rechit center #26725
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26725/9713
|
A new Pull Request was created by @Mourtz (Alex Mourtziapis) for master. It involves the following packages: Fireworks/Calo @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
+1 |
The center was not correct for Scintillator rechits due to geometry changes.
Now the center is being dumped with the rest of the geometry.
@rovere @deguio