Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dump HGCal rechit center #26725

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

Mourtz
Copy link
Contributor

@Mourtz Mourtz commented May 9, 2019

The center was not correct for Scintillator rechits due to geometry changes.
Now the center is being dumped with the rest of the geometry.

@rovere @deguio

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26725/9713

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

A new Pull Request was created by @Mourtz (Alex Mourtziapis) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented May 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/133/console Started: 2019/05/09 19:23

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3f6f0b8 into cms-sw:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants