-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HGCal KDTreeLinkerAlgoT.h: in the non-leaf case both left and right sons must exist #26896
Fix HGCal KDTreeLinkerAlgoT.h: in the non-leaf case both left and right sons must exist #26896
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26896/9939
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @perrotta for master. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As pointed out by the static analyzer, there was the possibility (which shouldn't never happen by construction but still possible in practice) that the code tries to access a null pointer.
This can be avoided by enforcing the check that both pointers that the code tries to access are non-null.
PR validation:
The code compiles correctly
@felicepantaleo @rovere