Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADC range for HGC scintillators #27377

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Fix ADC range for HGC scintillators #27377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47cb14
extend ADC range to avoid saturation
deguio Jun 27, 2019
1d49340
subtract ped mean from DIGIs when re-calibrating on-the-fly
deguio Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
scaleByArea = cms.bool(True),
noise = cms.PSet(refToPSet_ = cms.string("HGCAL_noise_heback")), #scales both for scint raddam and sipm dark current
calibDigis = cms.bool(True),
keV2MIP = cms.double(1./500.0),
keV2MIP = cms.double(1./675.0),
doTimeSamples = cms.bool(False),
nPEperMIP = cms.double(21.0),
nTotalPE = cms.double(7500),
Expand All @@ -188,9 +188,9 @@
# 0 only ADC, 1 ADC with pulse shape, 2 ADC+TDC with pulse shape
fwVersion = cms.uint32(0),
# n bits for the ADC (same as the silicon ROC)
adcNbits = cms.uint32(10),
adcNbits = cms.uint32(12),
# ADC saturation : in this case we use the same variable but fC=MIP
adcSaturation_fC = cms.double(68.5), #value chosen to have 1MIP at 15ADC
adcSaturation_fC = cms.double(275.0), #value chosen to have 1MIP at 15ADC
# threshold for digi production : in this case we use the same variable but fC=MIP
adcThreshold_fC = cms.double(0.5),
thresholdFollowsMIP = cms.bool(False)
Expand Down
2 changes: 1 addition & 1 deletion SimCalorimetry/HGCalSimProducers/src/HGCHEbackDigitizer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ void HGCHEbackDigitizer::runRealisticDigitizer(std::unique_ptr<HGCalDigiCollecti
//const float nPixelTot = nPixel + sqrt(nPixel) * CLHEP::RandGaussQ::shoot(engine, 0., 0.05); //FDG: just a note for now, par to be defined

//scale to calibrated response depending on the calibDigis_ flag
float totalMIPs = calibDigis_ ? (float)npe / scaledPePerMip : nPixel / nPEperMIP_;
float totalMIPs = calibDigis_ ? std::max((npe - meanN), 0.f) / scaledPePerMip : nPixel / nPEperMIP_;

if (debug && totalIniMIPs > 0) {
LogDebug("HGCHEbackDigitizer") << "npeS: " << npeS << " npeN: " << npeN << " npe: " << npe
Expand Down