Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles up to DataFormats #31165

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Clean BuildFiles up to DataFormats #31165

merged 3 commits into from
Aug 25, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30942).

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31165/17797

  • This PR adds an extra 88KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/CandAlgos
CommonTools/ParticleFlow
CommonTools/PileupAlgos
CommonTools/RecoAlgos
CommonTools/TriggerUtils
CommonTools/Utils
CondCore/AlignmentPlugins
CondCore/BeamSpotPlugins
CondCore/DBOutputService
CondCore/EcalPlugins
CondCore/HLTPlugins
CondCore/HcalPlugins
CondCore/PCLConfigPlugins
CondCore/RunInfoPlugins
CondCore/SiPixelPlugins
CondCore/SiStripPlugins
CondFormats/CSCObjects
CondFormats/Common
CondFormats/EcalObjects
CondFormats/RPCObjects
CondFormats/RecoMuonObjects
CondFormats/Serialization
CondTools/BTau
CondTools/BeamSpot
CondTools/DT
DQM/CSCMonitorModule
DQM/CTPPS
DQM/DataScouting
DQM/GEM
DQM/HLTEvF
DQM/MuonMonitor
DQM/SiStripCommissioningSources
DQMOffline/PFTau
DQMServices/Examples
RecoTauTag/RecoTau

@perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @fwyzard, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @forthommel, @abbiendi, @emilbols, @argiro, @jhgoh, @ahinzmann, @threus, @seemasharmafnal, @smoortga, @battibass, @makortel, @abdoulline, @watson-ij, @missirol, @dildick, @rociovilar, @barvic, @tocheng, @VinInn, @ferencek, @gkasieczka, @hatakeyamak, @mmusich, @ptcox, @mtosi, @clelange, @jdolen, @rchatter, @riga, @jan-kaspar, @JyothsnaKomaragiri, @mverzett, @dkotlins, @cbernet, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

<use name="boost_python"/>
</library>

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cannot be an intended change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's not! Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't catch it because it compiled anyway...

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31165/17798

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31165 was updated. @perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @fwyzard, @pohsun, @santocch can you please check and sign again.

@tlampen
Copy link
Contributor

tlampen commented Aug 20, 2020

+1

@jfernan2
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

+1

@santocch
Copy link

+1

@jpata
Copy link
Contributor

jpata commented Aug 24, 2020

+1

  • technical, tests pass with no reco differences as expected
  • this PR cleans up a number of BuildFiles from unused libraries based on grepping through includes
  • going through the commit history of the changed BuildFiles, I could not find cases where this PR undoes a previous recent change

@ggovi
Copy link
Contributor

ggovi commented Aug 25, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 25, 2020

+1

@cmsbuild cmsbuild merged commit 9aa3f20 into cms-sw:master Aug 25, 2020
@guitargeek guitargeek deleted the deps_up_to_DataFormats_2 branch August 25, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.