modernize CondTools/SiStrip

[mmusich]

resolves cms-AlCaDB/AlCaTools#35

PR description:

Migrate away from the deprecated edm::EDAnalyzer API in CondTools/SiStrip and other improvements.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

@cmsbuild, ping?

[mmusich]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25530

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/SiStrip (db)

@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/summary.html
COMMIT: b487bca
CMSSW: CMSSW_12_1_X_2021-09-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35415/18922/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Added esConsumes to ConversionTrackCandidateProducer #35345
• @thomreis ECAL remove unused SingleEleCalibSelector class #35396
• @CTPPS Fixes for PPS geometry on Stations #35399
• @ggovi Allow to preset timeout for connection on coral-supported Databases #35406
• @Dr15Jones Protect storage accounting UDP messages from NaN #35362
• @bsunanda Run3-gex94 Make new scenarios with the updated PPS Geometry #35404
• @Dr15Jones Use esConsumes in PileUpSubtractor #35392
• @mmusich Migrate away from deprecated edm::EDAnalyzer API in CalibTrackerand in modules inheriting from ConditionDBWriter #35401
• @francescobrivio Add new features to BeamSpotOnlineObjects #35338

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211043
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• comparison diffs are in the msg logger only, otherwise all looks good

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test
(to clean up the diff log)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18924/summary.html
COMMIT: b487bca
CMSSW: CMSSW_12_1_X_2021-09-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35415/18924/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[mmusich]

are now logs clean enough?

[perrotta]

+1