Migrate away from deprecated edm::EDAnalyzer API in CalibTrackerand in modules inheriting from ConditionDBWriter

[mmusich]

PR description:

Finalize migrate away from deprecated edm::EDAnalyzer API in CalibTracker and CommonTools/ConditionDBWriter

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35401/25507

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiPixelESProducers (alca)
• CalibTracker/SiPixelErrorEstimation (alca)
• CalibTracker/SiPixelLorentzAngle (alca)
• CalibTracker/SiPixelTools (alca)
• CalibTracker/SiStripESProducers (alca)
• CalibTracker/SiStripHitEfficiency (alca)
• CommonTools/ConditionDBWriter (db)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @OzAmram, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c58fd/18889/summary.html
COMMIT: d845384
CMSSW: CMSSW_12_1_X_2021-09-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35401/18889/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDx3DReader.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipBuilder.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipReader.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/TFormulaWriter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/TGraphWriter.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DBuilder.cc:18:42: error: invalid use of incomplete type 'class edm::EDAnalyzer'
   18 | class SiStripDeDx2DBuilder : public edm::EDAnalyzer {
      |                                          ^~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h:132,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-23-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DBuilder.cc:8:
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_1_X_2021-09-23-2300/src/FWCore/Framework/interface/Frameworkfwd.h:18:9: note: forward declaration of 'class edm::EDAnalyzer'


Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[mmusich]

whoops, forgot to check dependencies.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35401/25509

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #35401 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35401/25511

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #35401 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[mmusich]

@cmsbuild, please test

sorry for the trial & error, should be good now.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c58fd/18897/summary.html
COMMIT: 544da5b
CMSSW: CMSSW_12_1_X_2021-09-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35401/18897/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• diffs are only in the msg logger
• SA still finds deprecated modules, I took a note of that in Deprecated Legacy modules in CondTools/SiStrip cms-AlCaDB/AlCaTools#35 , to be resolved in another PR

[tvami]

+db

• signature needed because of ConditionDBWriter only, changes in the code are in line with the PR description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1