-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to preset timeout for connection on coral-supported Databases #35406
Allow to preset timeout for connection on coral-supported Databases #35406
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35406/25512
|
A new Pull Request was created by @ggovi for master. It involves the following packages:
@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b34d15/18896/summary.html Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@tvami thanks! |
PR description:
We are adding the access to the coral connectionTimeout parameter, to allow to preset values in the read-only workflows based on ESSource. Default value is 0=> no pool of idle connection.
The effect has been tested on Hilton for the HLT workflow. No visible performace change observe, but clear decrease of File descriptor opened ( the previous default value was 300 seconds )
Unit and integration test of CondCore packages are ok.