-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL remove unused SingleEleCalibSelector class #35396
ECAL remove unused SingleEleCalibSelector class #35396
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35396/25504
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35396/25505
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a659a/18900/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes the unused
SingleEleCalibSelector
class. It had been used during Run 1 to select events for the E/p calibration. Since Run 2 this is done with ECALELF instead. The class is not used anymore in CMSSW and neither in ECALELF code. Therefore, in coordination with ECAL calibration experts, we decided to remove it.PR validation:
Passes limited matrix workflows.