Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ttbar classic PU for 2017 with 2021 variant (10224->11834) in the short matrix #36320

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Dec 1, 2021

No description provided.

@slava77
Copy link
Contributor Author

slava77 commented Dec 1, 2021

@jpata
I think that this will be a better choice for reco comparisons than the 2017 PU wf, currently the only phase-1 MC with classic mixing

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36320/27057

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Dec 1, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d52e9/20911/summary.html
COMMIT: 8110a3b
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36320/20911/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d52e9/20911/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d52e9/20911/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13789 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 58198
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2983735
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: found differences in 2 / 40 workflows

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2021

+Upgrade

@jpata
Copy link
Contributor

jpata commented Dec 7, 2021

I think that this will be a better choice for reco comparisons than the 2017 PU wf, currently the only phase-1 MC with classic mixing

@slava77 can you clarify what you meant? For Run3, we are already profiling 11834.21, so probably I missed what you mean here.

@slava77
Copy link
Contributor Author

slava77 commented Dec 7, 2021

I think that this will be a better choice for reco comparisons than the 2017 PU wf, currently the only phase-1 MC with classic mixing

@slava77 can you clarify what you meant? For Run3, we are already profiling 11834.21, so probably I missed what you mean here.

This PR is about a workflow used in regular PR tests. We should have some minimal coverage of MC with pileup.

@slava77
Copy link
Contributor Author

slava77 commented Dec 17, 2021

@cms-sw/pdmv-l2
please clarify what else is needed for your signature.
The PR was open for more than 2 weeks without any feedback.

@kskovpen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cdc23d9 into cms-sw:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants