Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demote LogError about "L1GlobalDecision" in HLTPrescaleProvider #40654

Merged

Conversation

missirol
Copy link
Contributor

PR description:

This PR is a follow-up of #40481. It demotes the LogError issued by the class HLTPrescaleProvider about "L1GlobalDecision" to a LogDebug message.

This error message, which laments a failure in determining the prescales of the L1T algorithm "L1GlobalDecision", can be seen in the logs of several Run-3 workflows (see #40481 (comment)) [1]. This 'failure' is expected, because "L1GlobalDecision" is not a valid L1T algorithm, but a keyword used mainly by HLT to identify the global decision of the L1T trigger (Final OR, after vetos). For this reason, the LogError call is demoted to LogDebug.

Merely technical. No changes expected. Outputs are unchanged (except for the warning message).

[1] From step 3 of wf 11634.0 in a recent IB:

%MSG-e HLTPrescaleProvider:  PATTriggerProducer:patTrigger  31-Jan-2023 17:18:08 CET Run: 1 Event: 1
 Error in determining L1T prescales for HLT path: 'MC_Run3_PFScoutingPixelTracking_v18' with complex L1T seed: 'L1GlobalDecision' using L1TGlobalUtil: 
 isValid=1 l1tname/error/prescale 1
 0:L1GlobalDecision/0/-1.
%MSG

PR validation:

Checked that the error message disappears as expected in one of the relevant wfs (i.e. wf 11634.0).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40654/33982

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/HLTcore (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97b1dd/30302/summary.html
COMMIT: 628ab59
CMSSW: CMSSW_13_0_X_2023-01-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40654/30302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 67 lines from the logs
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555460
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Feb 1, 2023

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 1, 2023

+1

@cmsbuild cmsbuild merged commit 2c97877 into cms-sw:master Feb 1, 2023
@missirol missirol deleted the devel_fixHLTPrescProvForL1GlobalDec branch February 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants