-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demote LogError
about "L1GlobalDecision" in HLTPrescaleProvider
#40654
demote LogError
about "L1GlobalDecision" in HLTPrescaleProvider
#40654
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40654/33982
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97b1dd/30302/summary.html Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up of #40481. It demotes the
LogError
issued by the classHLTPrescaleProvider
about "L1GlobalDecision" to aLogDebug
message.This error message, which laments a failure in determining the prescales of the L1T algorithm "L1GlobalDecision", can be seen in the logs of several Run-3 workflows (see #40481 (comment)) [1]. This 'failure' is expected, because "L1GlobalDecision" is not a valid L1T algorithm, but a keyword used mainly by HLT to identify the global decision of the L1T trigger (Final OR, after vetos). For this reason, the
LogError
call is demoted toLogDebug
.Merely technical. No changes expected. Outputs are unchanged (except for the warning message).
[1] From step 3 of wf
11634.0
in a recent IB:PR validation:
Checked that the error message disappears as expected in one of the relevant wfs (i.e. wf
11634.0
).If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A