-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PerfTools/JeProf: Make a library that allows a call to jemalloc profile heap dump function. #40899
PerfTools/JeProf: Make a library that allows a call to jemalloc profile heap dump function. #40899
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40899/34382
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40899/34384 ERROR: Build errors found during clang-tidy run.
|
0f2b3a1
to
7a3b308
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40899/34385
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40899/34387
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@slava77 you might be interested in this |
30fe213
to
2bb37f4
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40899/34842
|
Pull request #40899 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df2625/31575/summary.html Comparison SummarySummary:
|
@makortel I think the is ready. |
+core Thanks! |
Can you please unhold. |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The proposed usage would be to add
<use="PerfTools/JeProf" />
to a packageBuildfile.xml
and then make a call tocms::jeprof::makeHeapDump()
in your module code to produce a Heap Profile with the filename passed as an argument when your module config is run withcmsRunJEProf