[DB-RECONSTRUCTION] [LLVM16]Fix mismatched bound warnings

[smuzaffar]

CLANG IBs (which now use clang16) has a lot of warnings like [a]. This PR fixes few of these

[a]

warning: argument 'xsum' of type 'float[11]' with mismatched bound [-Warray-parameter]
 void SiPixelTemplate::xsigma2(int fxpix, int lxpix, float sxthr, float xsum[11], float xsig2[11])

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41504/35377

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)

@clacaputo, @cmsbuild, @saumyaphor4252, @francescobrivio, @mandrenguyen, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d90b8e/32379/summary.html
COMMIT: d9764a0
CMSSW: CMSSW_13_1_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41504/32379/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 3862 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 4833
• DQMHistoTests: Total nulls: 55
• DQMHistoTests: Total successes: 3455967
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[francescobrivio]

I see a lot of differences in wf 23634.911, but I dont' think they come from this PR?

[perrotta]

I see a lot of differences in wf 23634.911, but I dont' think they come from this PR?

@francescobrivio this is annoyingly recurring these days, see #35109

[mmusich]

@perrotta

this is annoyingly recurring these days, see #41200

I don't think you are pointing to the right issue. This PR has changes all over the place (and certainly not in SiStrip as this is a Phase-2 wf).

[perrotta]

@mmusich you are right: the correct github issue is #35109 (I'll edit my entry here above)

[francescobrivio]

+db

• diffs in the DD4Hep workflow are unrelated to this PR and already documented in Instabilities in 11634.911 (DD4Hep) workflow comparisons #35109

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1