Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Adding cov matrix to fakeBS object #42239

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

dzuolo
Copy link
Contributor

@dzuolo dzuolo commented Jul 12, 2023

PR description:

Following the changes in PR #41597 a fake beam spot object is now effectively used at HLT if none of the two fits produced by the DQM client converge.
This caused crashes at HLT (see #41914) because no cov matrix, and hence no errors, was assigned to the bs fake object.
This PR adds a cov matrix with non-zero diagonal elements close to the ones returned by the fit.

PR validation:

Minor changes: code compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Backport to 13_1_X and 13_0_X will follow.

@mmusich
Copy link
Contributor

mmusich commented Jul 12, 2023

This caused crashes at HLT (see #41914) because no cov matrix, and hence no errors, was assigned to the bs fake object.

while I do agree that the covariance matrix should not be null, I think that the crash at HLT being caused by this, still needs to be proved.

@missirol FYI

@francescobrivio
Copy link
Contributor

type bug-fix

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42239/36257

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dzuolo (Davide Zuolo) for master.

It involves the following packages:

  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @consuegs, @clacaputo, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-247387/33659/summary.html
COMMIT: 27d670b
CMSSW: CMSSW_13_2_X_2023-07-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42239/33659/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193892
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193867
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • tests clean
  • PR according to description

@francescobrivio
Copy link
Contributor

urgent

  • @cms-sw/reconstruction-l2 a kind ping, the 130X backport of this should be merged asap and deployed in HLT

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants