-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Adding cov matrix to fakeBS object #42239
Conversation
type bug-fix |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42239/36257
|
A new Pull Request was created by @dzuolo (Davide Zuolo) for master. It involves the following packages:
@perrotta, @consuegs, @clacaputo, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-247387/33659/summary.html Comparison SummarySummary:
|
+1
|
urgent
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the changes in PR #41597 a fake beam spot object is now effectively used at HLT if none of the two fits produced by the DQM client converge.
This caused crashes at HLT (see #41914) because no cov matrix, and hence no errors, was assigned to the bs fake object.
This PR adds a cov matrix with non-zero diagonal elements close to the ones returned by the fit.
PR validation:
Minor changes: code compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. Backport to 13_1_X and 13_0_X will follow.