Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert BeamSpot fallback logic #42284

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

After discussion at the Tracking POG meeting on 17th July 2023, it was decided to revert the changes of the online BeamSpot fallback logic (used in HLT and Express) introduced in #41597.
This PR:

PR validation:

Code compiles + run successfully:

cmsRun DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py unitTest=True

Backport:

Not a backport, but backports to the data-taking releases will be provided soon.

FYI @gennai @dzuolo @lguzzi

mmusich and others added 3 commits July 17, 2023 15:31
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42284/36313

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @consuegs, @micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • addpkg = DQM/Integration

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ace4e/33725/summary.html
COMMIT: b21e838
CMSSW: CMSSW_13_2_X_2023-07-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42284/33725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 51 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195634
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3195578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing 13_0 backport at p5

@smuzaffar smuzaffar modified the milestones: CMSSW_13_2_X, CMSSW_13_3_X Jul 18, 2023
@francescobrivio
Copy link
Contributor Author

@smuzaffar

smuzaffar modified the milestones: CMSSW_13_2_X, CMSSW_13_3_X Jul 18, 2023

does this mean it will be included in both 13_2_X and 13_3_X? Or it has been moved to 13_3_X only and I need to provide a 13_2_X backport?

Also, @smuzaffar @rappoccio @perrotta, this "modification of milestone" happens with no explicit ping (mail notification) to the PR author and IMHO that's not a good practice because we might loose some backports. Is there a way to improve this behavior?

I can bring this up later today at the ORP meeting or open an issue (in cms-bot?) in case it's a better place to discuss this.

@smuzaffar
Copy link
Contributor

@francescobrivio , this will only be included in 13.3.X. For backport to 13.2.X , one needs to explicitly open a new PR

@emanueleusai
Copy link
Member

+1

  • p5 tests completed successfully and results are as expected

@mandrenguyen
Copy link
Contributor

+1

@francescobrivio
Copy link
Contributor Author

+db

  • since I'm moving more toward db stuff I let my @cms-sw/alca-l2 colleagues sign for alca 😄

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants