-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert BeamSpot fallback logic #42284
Revert BeamSpot fallback logic #42284
Conversation
…ake BS, by letting the BeamSpotOnlineProducer deal automatically with the arbitrated one" This reverts commit 4b35c95.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42284/36313
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @consuegs, @micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ace4e/33725/summary.html Comparison SummarySummary:
|
testing 13_0 backport at p5 |
does this mean it will be included in both 13_2_X and 13_3_X? Or it has been moved to 13_3_X only and I need to provide a 13_2_X backport? Also, @smuzaffar @rappoccio @perrotta, this "modification of milestone" happens with no explicit ping (mail notification) to the PR author and IMHO that's not a good practice because we might loose some backports. Is there a way to improve this behavior? I can bring this up later today at the ORP meeting or open an issue (in |
@francescobrivio , this will only be included in 13.3.X. For backport to 13.2.X , one needs to explicitly open a new PR |
+1
|
+1 |
+db
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
After discussion at the Tracking POG meeting on 17th July 2023, it was decided to revert the changes of the online BeamSpot fallback logic (used in HLT and Express) introduced in #41597.
This PR:
LogInfo
(s) inOnlineBeamSpotESProducer.cc
toLogWarning
(s) in order to better debug why sometimes HLT picks up the fake BeamSpot (see discussion in HLT crash in run-368566 (BasicSingleVertexState
error fromPFTauPrimaryVertexProducer
) #41914)bsChoice
plot title to improve clarityPR validation:
Code compiles + run successfully:
Backport:
Not a backport, but backports to the data-taking releases will be provided soon.
FYI @gennai @dzuolo @lguzzi