-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the time category for re-joining threads [13.2.x] #42534
Revert the time category for re-joining threads [13.2.x] #42534
Conversation
type bugfix |
backport #42533 |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa309f/34209/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Revert the category to which the time spent by for re-joining TBB threads is assigned.
While "considered as other" was our best guess, it has been seen to produce unreliable results, so revert to "not accounted" for the time being.
PR validation:
The HLT timing measurements confirmed that this change fixes the discrepancy between the throughput and the measured time per event.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #42533 to 13.2.x for the online operations.