Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the time category for re-joining threads [13.2.x] #42534

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 10, 2023

PR description:

Revert the category to which the time spent by for re-joining TBB threads is assigned.
While "considered as other" was our best guess, it has been seen to produce unreliable results, so revert to "not accounted" for the time being.

PR validation:

The HLT timing measurements confirmed that this change fixes the discrepancy between the throughput and the measured time per event.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42533 to 13.2.x for the online operations.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 10, 2023

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Aug 10, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 10, 2023

backport #42533

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 10, 2023

please test

@fwyzard fwyzard marked this pull request as draft August 10, 2023 15:02
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa309f/34209/summary.html
COMMIT: d8a3e8e
CMSSW: CMSSW_13_2_X_2023-08-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42534/34209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 226
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196090
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fwyzard fwyzard marked this pull request as ready for review August 11, 2023 11:54
@missirol
Copy link
Contributor

+hlt

This PR reverts a change which was introduced in #40391.

(Spurious DQM differences in some Phase-2 wfs are likely an example of #39754.)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9fac15c into cms-sw:CMSSW_13_2_X Aug 11, 2023
@fwyzard fwyzard deleted the FastTimerService_workaround branch August 13, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants