Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SoA range checking by default [14.0.x] #44987

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 16, 2024

PR description:

Enable SoA range checking by default.

PR validation:

None.

Backport status:

Backport of #44988 for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 16, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/SoATemplate (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented May 16, 2024

backport #44988

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39411/summary.html
COMMIT: 96a8e49
CMSSW: CMSSW_14_0_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44987/39411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3333953
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3333927
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #44987 was updated. @makortel, @fwyzard, @cmsbuild can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39432/summary.html
COMMIT: 679de0b
CMSSW: CMSSW_14_0_X_2024-05-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44987/39432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 5, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 5, 2024

please test

(to refresh the test results)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ddcd0/39716/summary.html
COMMIT: 679de0b
CMSSW: CMSSW_14_0_X_2024-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44987/39716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e8bf29c into cms-sw:CMSSW_14_0_X Jun 6, 2024
10 checks passed
@fwyzard fwyzard deleted the enable_SoA_range_checking_140x branch June 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants