guard against invalid output products from HLTL1TSeed

[missirol]

PR description:

This PR adds a safeguard to ensure that the plugin HLTL1TSeed does not add to the Event invalid references to L1T objects (by means of incorrect indices). For more information, see #44940 and CMSHLT-3216.

PR validation:

Tested on the reproducer in #44940 (comment).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_14_0_X

To be backported to CMSSW_14_0_X to avoid recurring HLT crashes (~1 every few days).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45047/40354

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@mmusich, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-353538/39530/summary.html
COMMIT: 34ac1a4
CMSSW: CMSSW_14_1_X_2024-05-26-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45047/39530/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

@cms-sw/orp-l2 @cms-sw/core-l2 can we also target to have this one in the 2300 IB?
So we have all three fixes included in master and we can eventually merge the backport needed for data-taking.

[antoniovilela]

+1