Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

matt2275 · 2024-07-09T04:00:33Z

PR description:

This is a draft pull request for adding new ZdcHitReconstuctor_Run3 and ZdcSimpleRecAlgo_Run3 to process QIE10 digis for the ZDC.

Additionally, ZDCRecHit was updated.

This update is being tested on CMSSW_14_1_0_pre5

PR validation:

No Validations tests have been run yet

Build Recipe

cmsrel CMSSW_14_1_0_pre5
cd CMSSW_14_1_0_pre5/src
cmsenv
git cms-merge-topic matt2275:Test_ZDCRecHit
scram b -j8

Note that this job will crash if RPD digis are processed without a temporary fix to HcalZDCDetId which is referenced here

Currently RPD digis are skipped so no crashes should occur

cmsbuild · 2024-07-09T04:00:59Z

cms-bot internal usage

cmsbuild · 2024-07-09T04:03:13Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40858

Found files with invalid states:
- RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
  - Added: 5eb6cf3
  - Modified: 8bd55c7
  - Deleted: b9e4878
- RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:
  - Added: 5eb6cf3
  - Modified: 8bd55c7
  - Deleted: b9e4878

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40858/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40858/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

mandrenguyen · 2024-07-12T16:25:08Z

@matt2275 why not just fix the code checks?

cmsbuild · 2024-07-15T03:59:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/40904

Found files with invalid states:
- RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.h:
  - Added: 5eb6cf3
  - Modified: 8bd55c7
  - Deleted: b9e4878
- RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructorRunThree.cc:
  - Added: 5eb6cf3
  - Modified: 8bd55c7
  - Deleted: b9e4878

cmsbuild · 2024-07-15T03:59:46Z

A new Pull Request was created by @matt2275 for master.

It involves the following packages:

DataFormats/HcalRecHit (reconstruction)
RecoLocalCalo/HcalRecAlgos (reconstruction)
RecoLocalCalo/HcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @mmusich, @rchatter, @rovere, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mandrenguyen · 2024-07-18T10:25:35Z

@matt2275 Please provide a recipe to test this code

matt2275 · 2024-07-18T19:58:07Z

There is a recipe to test the code here in the readme: https://github.com/matt2275/ZDCRecHit-Associated-Files/tree/main.

mandrenguyen · 2024-07-18T20:05:51Z

There is a recipe to test the code here in the readme: https://github.com/matt2275/ZDCRecHit-Associated-Files/tree/main.

The starting point is not from merging this PR. Can you provide a succinct recipe in the PR description please?
I don't feel like trying to parse the readme to figure out where to start.

matt2275 · 2024-07-19T01:16:57Z

There is a recipe to test the code here in the readme: https://github.com/matt2275/ZDCRecHit-Associated-Files/tree/main.

The starting point is not from merging this PR. Can you provide a succinct recipe in the PR description please? I don't feel like trying to parse the readme to figure out where to start.

I'm not positive what you mean by starting point. In the ReadMe file linked. I don't assume the PR is merged. The instructions start with starting a new CMSSW_14_1_0 working directory. From there, the relevant packages are added and files changed in this PR are updated and cmssw is rebuilt.

I'll add the instructions to PR description. I'm not sure the cms git command to download specific folders from a fork so I specify each file that needs to be downloaded from the Test_ZDCRecHit branch. Would git cms-merge-topic matt2275:Test_ZDCRecHit successfully merge the the Test_ZDCRecHit branch with CMSSW_14_1_0? If so, that would make the recipe significantly shorter.

abdoulline · 2024-07-19T05:20:02Z

Hi @matt2275
why didn't you try your (correct) assumption in the fresh local (e.g. 14_1_0_pre5) release area:
git cms-merge-topic matt2275:Test_ZDCRecHit

The you'd see that it:

checks out all your updates from the branch of interest (not from the fork...) and merges them into the local release area;
brings all the dependent 75 packages (for the subsequent compilation) the way 'git cms-checkdeps -a' [1] command does.

[1] to be always used to resolve packages dependencies (on the changes made), before compilation and running any (test) jobs.

matt2275 · 2024-07-19T19:50:18Z

Hi @abdoulline , I checked the git cms-merge-topic method last night however, there was an error compiling with a validation fix. I've attached a different method that only brings the changed packages however, I was not able to fully check the recipe due to disk quota issues. I know the recipe here works since it has been used by multiple people but it involved retrieving the updated files via wget.

mandrenguyen · 2024-07-19T20:09:27Z

@matt2275
Normally, a PR should be tested by relVal workflow.
I have understood that this is not possible at the moment.
However, in order to test the code I need a succinct recipe that starts from merge-topic and doesn't involve wgetting code.
My signature is required so nothing will move until that happens.
It's really not that difficult.

RecoLocalCalo/HcalRecAlgos/src/ZdcSimpleRecAlgo_Run3.cc

mandrenguyen · 2024-07-19T20:19:32Z

RecoLocalCalo/HcalRecAlgos/src/ZdcSimpleRecAlgo_Run3.cc

Is there a reason this is in src instead of plugins?

ZDCSimpleRecAlgo.cc is in src so I kept ZDCSimpleRecAlgo_Run3.cc in src as well

See the discussion on plugins vs src here:
https://cms-sw.github.io/cms_coding_rules.html

From reading the discussion on plugin vs src, ZDCSimpleRecAlgo_Run3 should be in the src directory as it used by ZDCHitReconstructor_Run3.cc which is the EDProducer for ZdcRecHits.

And ZDCHitReconstructor_Run3.cc ?
Shouldn't that be in plugins?

I think it should be in the plugins folder, there is no plugins directory in RecoLocalCalo/HCalRecProducers. I can create the plugins directory and put ZDCHitReconstructor_Run.cc/ .h

Yes, you can create the plugins directory.

RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructor_Run3.cc

cmsbuild · 2024-08-23T19:57:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45407/41515

cmsbuild · 2024-08-23T19:58:03Z

Pull request #45407 was updated. @antoniovilela, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

mandrenguyen · 2024-08-23T20:00:03Z

please abort

mandrenguyen · 2024-08-23T20:03:19Z

please test

cmsbuild · 2024-08-24T00:56:17Z

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7862bf/41105/summary.html
COMMIT: 0dee346
CMSSW: CMSSW_14_1_X_2024-08-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45407/41105/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test testPhase2SkimmedGeometry had ERRORS
---> test PrimaryVertex had ERRORS

RelVals-INPUT

2024.4050052024.405005_RunMuon02024F_50k/step1_dasquery.log
2024.4110052024.411005_RunParkingSingleMuon02024F_50k/step1_dasquery.log
2024.100052024.10005_RunBTagMu2024C_500k/step1_dasquery.log

Expand to see more relval errors ...

2024.1001
2024.10105
2024.1011
2024.30205
2024.3021
2024.3031
2024.3111
2024.31105
2024.4111
2024.4121
2024.41105
2024.405005
2024.411005
2024.10005
2024.1001
2024.10105
2024.1011
2024.30205
2024.3021
2024.3031
2024.31105
2024.3111
2024.41105
2024.4111
2024.4121

Comparison Summary

Summary:

You potentially added 4 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3742758
DQMHistoTests: Total failures: 1287
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3741451
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 178 edm output root files, 49 DQM output files
TriggerResults: no differences found

abdoulline · 2024-08-24T04:44:52Z

👍

mandrenguyen · 2024-08-24T06:51:48Z

ignore tests-rejected with ib-failure

mandrenguyen · 2024-08-24T06:53:09Z

+1

cmsbuild · 2024-08-24T06:53:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will be automatically merged.

dan131riley · 2024-08-29T13:13:00Z

ASAN IB is getting heap buffer overflows in WF 141.901, 141.902, 142, 142.901 and 142.902 (so far).

Log: https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_2_ASAN_X_2024-08-28-2300/pyRelValMatrixLogs/run/141.901_RunUPC2023/step2_RunUPC2023.log#/114-114

Begin processing the 1st record. Run 375463, Event 48286833, LumiSection 52 on stream 1 at 29-Aug-2024 08:59:33.869 CEST
Begin processing the 2nd record. Run 375463, Event 48769160, LumiSection 52 on stream 0 at 29-Aug-2024 08:59:33.871 CEST
Begin processing the 3rd record. Run 375463, Event 48769165, LumiSection 52 on stream 2 at 29-Aug-2024 08:59:33.872 CEST
Begin processing the 4th record. Run 375463, Event 48769183, LumiSection 52 on stream 3 at 29-Aug-2024 08:59:33.874 CEST
=================================================================
==3043192==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604005b10740 at pc 0x14ed887e44f4 bp 0x14ed7b8ccb50 sp 0x14ed7b8ccb48
READ of size 8 at 0x604005b10740 thread T2
    #0 0x14ed887e44f3 in ZdcSimpleRecAlgo_Run3::reco0(QIE10DataFrame const&, HcalCoder const&, HcalCalibrations const&, HcalPedestal const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, std::vector<unsigned int, std::allocator<unsigned int> > const&) const (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libRecoLocalCaloHcalRecAlgos.so+0x2a14f3)
    #1 0x14ed887e4621 in ZdcSimpleRecAlgo_Run3::reconstruct(QIE10DataFrame const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, HcalCoder const&, HcalCalibrations const&, HcalPedestal const&) const (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libRecoLocalCaloHcalRecAlgos.so+0x2a1621)
    #2 0x14ed3bceb618 in ZdcHitReconstructor_Run3::produce(edm::Event&, edm::EventSetup const&) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/pluginRecoLocalCaloHcalRecProducersPlugin.so+0x36618)
    #3 0x14ede1e1b86b in edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0xabc86b)
    #4 0x14ede1d78648 in edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0xa19648)
    #5 0x14ede19b1e47 in decltype ({parm#1}()) edm::convertException::wrap<edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}>(edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x652e47)
    #6 0x14ede19b2529 in std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x653529)
    #7 0x14ede19bf74d in edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x66074d)
    #8 0x14ede271648e in tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreConcurrency.so+0x1548e)
    #9 0x14eddf142b3a in tbb::detail::d1::task* tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::outermost_worker_waiter>(tbb::detail::d1::task*, tbb::detail::r1::outermost_worker_waiter&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/task_dispatcher.h:322
    #10 0x14eddf142b3a in tbb::detail::d1::task* tbb::detail::r1::task_dispatcher::local_wait_for_all<tbb::detail::r1::outermost_worker_waiter>(tbb::detail::d1::task*, tbb::detail::r1::outermost_worker_waiter&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/task_dispatcher.h:458
    #11 0x14eddf142b3a in tbb::detail::r1::arena::process(tbb::detail::r1::thread_data&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/arena.cpp:137
    #12 0x14eddf142b3a in tbb::detail::r1::market::process(rml::job&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/market.cpp:599
    #13 0x14eddf144ced in tbb::detail::r1::rml::private_worker::run() /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:271
    #14 0x14eddf144ced in tbb::detail::r1::rml::private_worker::thread_routine(void*) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:221
    #15 0x14edde2911c9 in start_thread (/lib64/libpthread.so.0+0x81c9)
    #16 0x14edddeec8d2 in __GI___clone (/lib64/libc.so.6+0x398d2)

0x604005b10740 is located 0 bytes to the right of 48-byte region [0x604005b10710,0x604005b10740)
allocated by thread T2 here:
    #0 0x14ede208f6d8 in operator new(unsigned long) ../../../../libsanitizer/asan/asan_new_delete.cpp:95
    #1 0x14edafc58caf in CaloSamples::CaloSamples(DetId const&, int) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libCalibFormatsCaloObjects.so+0xfcaf)
    #2 0x14edb06ecf94 in void HcalCoderDb::adc2fC_<QIE10DataFrame>(QIE10DataFrame const&, CaloSamples&) const (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libCalibFormatsHcalObjects.so+0x1cf94)
    #3 0x14ed887e089c in ZdcSimpleRecAlgo_Run3::reco0(QIE10DataFrame const&, HcalCoder const&, HcalCalibrations const&, HcalPedestal const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, std::vector<unsigned int, std::allocator<unsigned int> > const&) const (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libRecoLocalCaloHcalRecAlgos.so+0x29d89c)
    #4 0x14ed887e4621 in ZdcSimpleRecAlgo_Run3::reconstruct(QIE10DataFrame const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, HcalCoder const&, HcalCalibrations const&, HcalPedestal const&) const (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libRecoLocalCaloHcalRecAlgos.so+0x2a1621)
    #5 0x14ed3bceb618 in ZdcHitReconstructor_Run3::produce(edm::Event&, edm::EventSetup const&) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/pluginRecoLocalCaloHcalRecProducersPlugin.so+0x36618)
    #6 0x14ede1e1b86b in edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0xabc86b)
    #7 0x14ede1d78648 in edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0xa19648)
    #8 0x14ede19b1e47 in decltype ({parm#1}()) edm::convertException::wrap<edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}>(edm::Worker::runModule<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*)::{lambda()#1}) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x652e47)
    #9 0x14ede19b2529 in std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x653529)
    #10 0x14ede19bf74d in edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so+0x66074d)
    #11 0x14ede271648e in tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libFWCoreConcurrency.so+0x1548e)
    #12 0x14eddf142b3a in tbb::detail::d1::task* tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::outermost_worker_waiter>(tbb::detail::d1::task*, tbb::detail::r1::outermost_worker_waiter&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/task_dispatcher.h:322
    #13 0x14eddf142b3a in tbb::detail::d1::task* tbb::detail::r1::task_dispatcher::local_wait_for_all<tbb::detail::r1::outermost_worker_waiter>(tbb::detail::d1::task*, tbb::detail::r1::outermost_worker_waiter&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/task_dispatcher.h:458
    #14 0x14eddf142b3a in tbb::detail::r1::arena::process(tbb::detail::r1::thread_data&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/arena.cpp:137
    #15 0x14eddf142b3a in tbb::detail::r1::market::process(rml::job&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/market.cpp:599
    #16 0x14eddf144ced in tbb::detail::r1::rml::private_worker::run() /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:271
    #17 0x14eddf144ced in tbb::detail::r1::rml::private_worker::thread_routine(void*) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:221

Thread T2 created by T0 here:
    #0 0x14ede2020136 in __interceptor_pthread_create ../../../../libsanitizer/asan/asan_interceptors.cpp:207
    #1 0x14eddf14434f in tbb::detail::r1::rml::internal::thread_monitor::launch(void* (*)(void*), void*, unsigned long) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/rml_thread_monitor.h:208
    #2 0x14eddf14434f in tbb::detail::r1::rml::private_worker::wake_or_launch() /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:305
    #3 0x14eddf14434f in tbb::detail::r1::rml::private_server::wake_some(int) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/tbb-v2021.9.0/src/tbb/private_server.cpp:412

SUMMARY: AddressSanitizer: heap-buffer-overflow (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02852/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_ASAN_X_2024-08-28-2300/lib/el8_amd64_gcc12/libRecoLocalCaloHcalRecAlgos.so+0x2a14f3) in ZdcSimpleRecAlgo_Run3::reco0(QIE10DataFrame const&, HcalCoder const&, HcalCalibrations const&, HcalPedestal const&, std::vector<unsigned int, std::allocator<unsigned int> > const&, std::vector<unsigned int, std::allocator<unsigned int> > const&) const
Shadow bytes around the buggy address:
  0x0c0880b5a090: fa fa 00 00 00 00 01 fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a0a0: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a0b0: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a0c0: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a0d0: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 07
=>0x0c0880b5a0e0: fa fa 00 00 00 00 00 00[fa]fa 00 00 00 00 00 01
  0x0c0880b5a0f0: fa fa fd fd fd fd fd fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a100: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c0880b5a110: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 03 fa
  0x0c0880b5a120: fa fa 00 00 00 00 00 00 fa fa 00 00 00 00 00 fa
  0x0c0880b5a130: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==3043192==ABORTING

hjbossi · 2024-08-30T14:37:23Z

Okay thanks for alerting us, we can take a look!

matt2275 · 2024-09-03T19:03:13Z

Thanks for raising the issue. Bug fix PRs are here for master and 14_1_X

mandrenguyen · 2024-09-06T10:00:48Z

@dan131riley I think I don't see the issue anymore in CMSSW_14_2_X_2024-09-04-2300
Do you confirm?
That would confirm that the fix in #45868 was effective.

cmsbuild added this to the CMSSW_14_1_X milestone Jul 9, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jul 9, 2024

cmsbuild added code-checks-rejected changes-dataformats and removed code-checks-pending labels Jul 9, 2024

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2024

matt2275 marked this pull request as ready for review July 19, 2024 19:54

mandrenguyen reviewed Jul 19, 2024

View reviewed changes

RecoLocalCalo/HcalRecAlgos/src/ZdcSimpleRecAlgo_Run3.cc Outdated Show resolved Hide resolved

mandrenguyen reviewed Jul 19, 2024

View reviewed changes

RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructor_Run3.cc Outdated Show resolved Hide resolved

mandrenguyen reviewed Jul 19, 2024

View reviewed changes

RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructor_Run3.cc Outdated Show resolved Hide resolved

cmsbuild added the code-checks-pending label Aug 23, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 23, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 24, 2024

cmsbuild added tests-approved tests-ib-failure and removed tests-rejected labels Aug 24, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Aug 24, 2024

cmsbuild merged commit 10cbe91 into cms-sw:master Aug 24, 2024
10 of 12 checks passed

This was referenced Sep 3, 2024

Fix issue with ZDCSimpleRecAlgo_Run3.cc #45868

Merged

[14_1_X] Fix issue with ZdcSimpleRecAlgo_Run3.cc #45869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

matt2275 commented Jul 9, 2024 •

edited

Loading

cmsbuild commented Jul 9, 2024 •

edited

Loading

cmsbuild commented Jul 9, 2024

mandrenguyen commented Jul 12, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

mandrenguyen commented Jul 18, 2024

matt2275 commented Jul 18, 2024

mandrenguyen commented Jul 18, 2024

matt2275 commented Jul 19, 2024

abdoulline commented Jul 19, 2024 •

edited

Loading

matt2275 commented Jul 19, 2024

mandrenguyen commented Jul 19, 2024

mandrenguyen Jul 19, 2024

matt2275 Jul 22, 2024

mandrenguyen Jul 23, 2024

matt2275 Jul 29, 2024

mandrenguyen Jul 29, 2024

matt2275 Jul 29, 2024

mandrenguyen Aug 17, 2024

cmsbuild commented Aug 23, 2024

cmsbuild commented Aug 23, 2024

mandrenguyen commented Aug 23, 2024

mandrenguyen commented Aug 23, 2024

cmsbuild commented Aug 24, 2024

abdoulline commented Aug 24, 2024

mandrenguyen commented Aug 24, 2024

mandrenguyen commented Aug 24, 2024

cmsbuild commented Aug 24, 2024

dan131riley commented Aug 29, 2024

hjbossi commented Aug 30, 2024 •

edited

Loading

matt2275 commented Sep 3, 2024

mandrenguyen commented Sep 6, 2024

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

Added new ZDCHitReconstructor and ZDCRecAlgo to work with QIE10 Digis and Updated ZDCRecHit #45407

Conversation

matt2275 commented Jul 9, 2024 • edited Loading

PR description:

PR validation:

Build Recipe

cmsbuild commented Jul 9, 2024 • edited Loading

cmsbuild commented Jul 9, 2024

mandrenguyen commented Jul 12, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

mandrenguyen commented Jul 18, 2024

matt2275 commented Jul 18, 2024

mandrenguyen commented Jul 18, 2024

matt2275 commented Jul 19, 2024

abdoulline commented Jul 19, 2024 • edited Loading

matt2275 commented Jul 19, 2024

mandrenguyen commented Jul 19, 2024

mandrenguyen Jul 19, 2024

Choose a reason for hiding this comment

matt2275 Jul 22, 2024

Choose a reason for hiding this comment

mandrenguyen Jul 23, 2024

Choose a reason for hiding this comment

matt2275 Jul 29, 2024

Choose a reason for hiding this comment

mandrenguyen Jul 29, 2024

Choose a reason for hiding this comment

matt2275 Jul 29, 2024

Choose a reason for hiding this comment

mandrenguyen Aug 17, 2024

Choose a reason for hiding this comment

cmsbuild commented Aug 23, 2024

cmsbuild commented Aug 23, 2024

mandrenguyen commented Aug 23, 2024

mandrenguyen commented Aug 23, 2024

cmsbuild commented Aug 24, 2024

Unit Tests

RelVals-INPUT

Comparison Summary

abdoulline commented Aug 24, 2024

mandrenguyen commented Aug 24, 2024

mandrenguyen commented Aug 24, 2024

cmsbuild commented Aug 24, 2024

dan131riley commented Aug 29, 2024

hjbossi commented Aug 30, 2024 • edited Loading

matt2275 commented Sep 3, 2024

mandrenguyen commented Sep 6, 2024

matt2275 commented Jul 9, 2024 •

edited

Loading

cmsbuild commented Jul 9, 2024 •

edited

Loading

abdoulline commented Jul 19, 2024 •

edited

Loading

hjbossi commented Aug 30, 2024 •

edited

Loading