Alpaka Pixel: Reading layerStart at Runtime and Variable thePitch*

[AdrianoDee]

PR description:

This PR proposes two things:

• reading the layer module start numbers from the TrackerGeometry when filling the PixelCPEFastParamsHost ESProduct. This makes TrackerTraits::layerStart obsolete;
• moving the pixel pitch from CommonParams to DetParams since, with T33, 3D sensors have a different pitch (tiny difference, but still);

It's a first piece of a wider effort to allow more flexible the detector geometry that can be used by the pixel CA.

Note: the layerStart array in Geometry/CommonTopologies/interface/SimplePixelTopology.h could be dropped but at the moment is needed by the old CUDA modules.

This solves #45177 and allows to run Alpaka pixel tracks on D110.

PR validation:

Running 29634.402

[cmsbuild]

cms-bot internal usage

[AdrianoDee]

test parameters:

• workflows = 29634.402
• workflows_gpu = 29634.402
• relvals_opt = --what upgrade
• relvals_opt_gpu = --what upgrade

[AdrianoDee]

enable gpu

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/40867

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/40867/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/40867/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/40869

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
• Geometry/CommonTopologies (geometry)
• RecoLocalTracker/SiPixelRecHits (reconstruction)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @bsunanda, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @martinamalberti, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/40871

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45421/41152

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Geometry/CommonTopologies/interface/SimplePixelTopology.h modified in PR(s): Allowing Jumping BPix2->FPix2 For Pixel Doublets (and Alpaka Pixel Triplets *.406 wf) #45478

[cmsbuild]

Pull request #45421 was updated. @Dr15Jones, @bsunanda, @civanch, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mdhildreth can you please check and sign again.

[fwyzard]

+heterogeneous

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-596766/40774/summary.html
COMMIT: f7a2d08
CMSSW: CMSSW_14_1_X_2024-08-05-0800/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45421/40774/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.402 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 29 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 90 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3439927
• DQMHistoTests: Total failures: 2463
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3437444
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 203 log files, 174 edm output root files, 46 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.402 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 51 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 52972
• DQMHistoTests: Total failures: 669
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 52303
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 27 log files, 34 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[mandrenguyen]

unhold

[mandrenguyen]

@cms-sw/geometry-l2 can you have a look please?

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1