-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestDQMOfflineConfigurationGotAll: increase the number of considered DQM seqs #45507
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45507/40973 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 16KB to repository
Comparison SummarySummary:
|
Fixes #45486 |
@cms-sw/dqm-l2 , can you please review and approve this? This is just a technical fix for the unit test |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Looks like we now have 320 DQM sequences while the unit test
TestDQMOfflineConfigurationGotAll
was expacting 311. This PR updates the total number of to 320. This should fix the failing unit test in 14.1.X IBs