Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subjet info in MiniAOD #7549

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Feb 3, 2015

This PR adds subjet information to the fat jets stored in MiniAOD (slimmedJetsAK8). The information is stored as userFloats for SoftDrop subjets and CMS Top Tagger subjets.

The impact on the MiniAOD event size was checked by running over 500 events from /RelValProdTTbar_13/CMSSW_7_4_0_pre5-MCRUN2_73_V7-v1/AODSIM and the observed increase in the event size was ~0.75%.

@rappoccio @arizzi

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Subjet info in MiniAOD

It involves the following packages:

CommonTools/RecoAlgos
PhysicsTools/PatAlgos

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2015

-1
Tested at: 2a10756
When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 04-Feb-2015 02:35:42 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETs'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetJetEnUp'
   [5] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMet'
   [6] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'patPFMETcorrJetSmearing'
   [7] Calling produce method for unscheduled module PATJetCleaner/'patJetsAK4PFForMetUncNotOverlappingWithLeptonsForJetMEtUncertainty'
   [8] Calling produce method for unscheduled module PATJetSelector/'selectedPatJetsAK4PFForMetUnc'
   [9] Calling produce method for unscheduled module PATJetProducer/'patJetsAK4PFForMetUnc'
   [10] Calling produce method for unscheduled module GenJetMatcher/'patJetGenJetMatchAK4PFForMetUnc'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: ak4GenJetsNoNu
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1306.0 step5

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 04-Feb-2015 02:42:44 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETs'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetJetEnUp'
   [5] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMet'
   [6] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'patPFMETcorrJetSmearing'
   [7] Calling produce method for unscheduled module PATJetCleaner/'patJetsAK4PFForMetUncNotOverlappingWithLeptonsForJetMEtUncertainty'
   [8] Calling produce method for unscheduled module PATJetSelector/'selectedPatJetsAK4PFForMetUnc'
   [9] Calling produce method for unscheduled module PATJetProducer/'patJetsAK4PFForMetUnc'
   [10] Calling produce method for unscheduled module GenJetMatcher/'patJetGenJetMatchAK4PFForMetUnc'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: ak4GenJetsNoNu
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 04-Feb-2015 02:50:06 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETs'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetJetEnUp'
   [5] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMet'
   [6] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'patPFMETcorrJetSmearing'
   [7] Calling produce method for unscheduled module PATJetCleaner/'patJetsAK4PFForMetUncNotOverlappingWithLeptonsForJetMEtUncertainty'
   [8] Calling produce method for unscheduled module PATJetSelector/'selectedPatJetsAK4PFForMetUnc'
   [9] Calling produce method for unscheduled module PATJetProducer/'patJetsAK4PFForMetUnc'
   [10] Calling produce method for unscheduled module GenJetMatcher/'patJetGenJetMatchAK4PFForMetUnc'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: ak4GenJetsNoNu
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 04-Feb-2015 03:25:43 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETs'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetJetEnUp'
   [5] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMet'
   [6] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'patPFMETcorrJetSmearing'
   [7] Calling produce method for unscheduled module PATJetCleaner/'patJetsAK4PFForMetUncNotOverlappingWithLeptonsForJetMEtUncertainty'
   [8] Calling produce method for unscheduled module PATJetSelector/'selectedPatJetsAK4PFForMetUnc'
   [9] Calling produce method for unscheduled module PATJetProducer/'patJetsAK4PFForMetUnc'
   [10] Calling produce method for unscheduled module GenJetMatcher/'patJetGenJetMatchAK4PFForMetUnc'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: ak4GenJetsNoNu
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7549/2344/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2015

@ferencek
Copy link
Contributor Author

ferencek commented Feb 5, 2015

Since an alternative approach is being pursued, I am closing this PR. Nevertheless, I will create a new PR containing the JetDeltaRValueMapProducer modifications from this PR. Those should be useful more generally and are backward compatible.

@ferencek
Copy link
Contributor Author

ferencek commented Feb 7, 2015

Just for reference, subjets in MiniAOD are now being addressed by #7606.

@ferencek ferencek deleted the B2GMiniAODSubJets_PATJetMiniAODImprovements_from-CMSSW_7_4_0_pre6 branch March 16, 2015 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants