Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btag cond format #7633

Closed
wants to merge 15 commits into from
Closed

Conversation

HeinerTholen
Copy link
Contributor

DB file creation with cmsRun is the most significant change. Small adjustments apart from that.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

A new Pull Request was created by @HeinAtCERN for CMSSW_7_4_X.

Btag cond format

It involves the following packages:

RecoBTag/PerformanceDB

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2015

@cmsbuild
Copy link
Contributor

Pull request #7633 was updated. @nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @ggovi, @mmusich can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2015

-1

this doesn't merge anymore according to github.
Please check on top of 740pre7 or better yet 74X

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2015

Auto-merging RecoBTag/PerformanceDB/test/BTagCalibrationStandalone.cc
CONFLICT (content): Merge conflict in RecoBTag/PerformanceDB/test/BTagCalibrationStandalone.cc
Auto-merging CondFormats/BTauObjects/src/BTagCalibration.cc
CONFLICT (content): Merge conflict in CondFormats/BTauObjects/src/BTagCalibration.cc

@davidlange6
Copy link
Contributor

closing in 74x - there is the same PR open in 75x (now the development release)

@HeinerTholen HeinerTholen mentioned this pull request Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants