Made calling TGenCollectionStreamer::Generate thread safe #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although each thread will get its own copy of TGenCollectionStreamer, that copy is made by calling Generate on a global instance of the class. Therefore Generate needs to be thread safe. This translates to requiring TGenCollectionProxy::Initialize be thread safe. This required that TGenCollectionProxy::fValue be atomic and be the last value to be set in TGenCollectionProxy::InitializeEx.
ktf
added a commit
that referenced
this pull request
Mar 10, 2015
…ateThreadSafe_cmsv6-02-05 Made calling TGenCollectionStreamer::Generate thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although each thread will get its own copy of TGenCollectionStreamer,
that copy is made by calling Generate on a global instance of the class.
Therefore Generate needs to be thread safe. This translates to requiring
TGenCollectionProxy::Initialize be thread safe. This required that
TGenCollectionProxy::fValue be atomic and be the last value to be set
in TGenCollectionProxy::InitializeEx.