CAT Hackathon: retrieving normalization for skimmed files #78
Conversation
| @@ -39,9 +41,9 @@ def __init__(self, fname, **kwargs): | |||
| self.year = kwargs.get('year', 2022 ) # integer, e.g. 2017, 2018 | |||
| self.era = kwargs.get('era', '2022postEE' ) # string, e.g. '2017', 'UL2017' | |||
| self.ees = kwargs.get('ees', 1.0 ) # electron energy scale | |||
| self.tes = kwargs.get('tes', None ) # tau energy scale; if None, recommended values are applied | |||
There was a problem hiding this comment.
@jmalvaso @pmastrap In general it's better to not change these default settings if it's for your own personal reasons, because it might break other people's setups. If you want to disable this, you need to do so via your sample list or the way you define the channel. (Anyway, I'll try to make this easier / more clear in the new configuration paradigm.)
There was a problem hiding this comment.
@IzaakWN Should I restore these setting to the default value and create a new pull request or, for this time, it is fine like this?
There was a problem hiding this comment.
I would suggest to just add a commit that undoes changing these defaults if that's okay with you?
There was a problem hiding this comment.
Yes, it's fine. I will do it asap
There was a problem hiding this comment.
@IzaakWN I think I added the commit in the proper way, but please let me know if it's ok now
No description provided.