code used to produce 2023C,D SF #81
Conversation
…stogram names; replace parallel with nthreads; put back RDF.RunGraphs
…stogram names; replace parallel with nthreads; put back RDF.RunGraphs
| @@ -117,3 +117,5 @@ To create ROOT files including the measured SFs please install [`TauIDSFs` tool] | |||
| Modify the `TauIDSFs/utils/createSFFiles.py` script to include your measured SFs into the script. | |||
| Finally, run the `TauFW/scripts/tau_createROOT.sh` to generate your ROOT files. They will be created into `TauFW/scripts/data/` | |||
| IMPORTANT: please comment and do not delete older SFs | |||
|
|
|||
| The latest code used to create root files for SF can be taken from [here](https://github.com/saswatinandan/TauFW/blob/master/Fitter/createroot_TES.py) | |||
There was a problem hiding this comment.
Should this link be updated?
There was a problem hiding this comment.
I used this code to produce the root files containing all the sfs. If there is any other code to produce this, it can be linked here.
There was a problem hiding this comment.
I think that this should be the README to enrich/update with the latest version of scripts running command.
|
Hi Saswati, thank you for the quick follow-ups! Barring some minor comments above and maybe pending review from @pmastrap, I think this PR is almost ready to be merged. |
| @@ -90,6 +105,7 @@ def harvest(setup, year, obs, **kwargs): | |||
| scaleFactor = 1.0 | |||
| if "scaleFactor" in sysDef: | |||
| scaleFactor = sysDef["scaleFactor"] | |||
| if "name" in sysDef: sysDef["processes"] = check_integral(filename, sysDef["processes"], sysDef["name"], region) | |||
There was a problem hiding this comment.
what's this new function for ? can you put a comment line to explain, pls?
There was a problem hiding this comment.
For some systematic, I saw that statistics was too small, actually zero, and in some cases it was giving nan value. If those samples were removed from the samples list, nan value was removed.
There was a problem hiding this comment.
Hello @saswatinandan @IzaakWN, just done with the review.
I think that the PR is in a good shape with the exception of few small changes, needed before merging.
Additionally, I would suggest the update of the TauES_ID README with prompt instructions to run the full workflow, to make it easier for future measurements.
This reverts commit 99aae81.
Commands used to create 2023C/D SF
|
Hi, I tried to implement all the comments as much as possible, if still there is some problem, please let me know. |
|
Thanks @saswatinandan for all the work! I think the only thing missing is the control on the era in ModuleMuMu. |
|
I think this PR is ready to be merged @IzaakWN |
No description provided.