Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update VSmu SFs for UL #8

Merged
merged 2 commits into from
Jan 10, 2022
Merged

update VSmu SFs for UL #8

merged 2 commits into from
Jan 10, 2022

Conversation

YWen-AI
Copy link

@YWen-AI YWen-AI commented Jan 7, 2022

As the title said

@IzaakWN
Copy link
Collaborator

IzaakWN commented Jan 10, 2022 •
edited
Loading

Hey Yiwen, thanks! Can you just add back the pre-UL SFs in the dictionary, please? You can comment it out if you wish, it's just for future reference, I prefer to keep it.

@YWen-AI
Copy link
Author

YWen-AI commented Jan 10, 2022

@IzaakWN DONE

@IzaakWN
Copy link
Collaborator

IzaakWN commented Jan 10, 2022

Looks good! Merging...

@IzaakWN IzaakWN merged commit 587bedb into cms-tau-pog:TauPOG_v2 Jan 10, 2022
@IzaakWN IzaakWN mentioned this pull request Jan 11, 2022
Merged
@IzaakWN
Copy link
Collaborator

IzaakWN commented Jan 11, 2022 •
edited
Loading

Sorry, forgot to mention this earlier: As discussed in cms-tau-pog/TauFW#9, the script for VSmu JSONs should be maintained in the TauFW, rather than here. The scripts in this repo were more meant for developing and validating the JSON format & scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YWen-AI @IzaakWN