-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for firing mortar. #6054
Merged
Merged
Fix for firing mortar. #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I blame zonespace for forcing me to fix the one letter vars |
SabreML
approved these changes
Mar 30, 2024
Which bit was causing it btw? |
cm13-github
added a commit
that referenced
this pull request
Mar 30, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Followup to #5940.
I understand the newfashioned crusade against old singleletter variables, but when engaging in it, can we please ensure that all the renamed variables stay effectively the same with no wires crossed? Or at least test our code?
Explain why it's good for the game
Is fix.
Changelog
🆑
fix: Mortar works properly once again.
/:cl: