Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for firing mortar. #6054

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Fix for firing mortar. #6054

merged 2 commits into from
Mar 31, 2024

Conversation

Segrain
Copy link
Contributor

@Segrain Segrain commented Mar 30, 2024

About the pull request

Followup to #5940.
I understand the newfashioned crusade against old singleletter variables, but when engaging in it, can we please ensure that all the renamed variables stay effectively the same with no wires crossed? Or at least test our code?

Explain why it's good for the game

Is fix.

Changelog

🆑
fix: Mortar works properly once again.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 30, 2024
cm13-github added a commit that referenced this pull request Mar 30, 2024
@Segrain Segrain mentioned this pull request Mar 30, 2024
@iloveloopers
Copy link
Contributor

I blame zonespace for forcing me to fix the one letter vars

@SabreML
Copy link
Member

SabreML commented Mar 30, 2024

Which bit was causing it btw?

@Segrain
Copy link
Contributor Author

Segrain commented Mar 30, 2024

Which bit was causing it btw?

image
Used to be T from way back in the procedure for the target turf and G set in the end to make shards rain on mortar if fired under glass roof, accidentally fed that mortar turf into shell's targeting instead.

cm13-github added a commit that referenced this pull request Mar 30, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
cm13-github added a commit that referenced this pull request Mar 31, 2024
@SabreML SabreML added this pull request to the merge queue Mar 31, 2024
Merged via the queue into cmss13-devs:master with commit 6c30334 Mar 31, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants