Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated ARIA IDs Used In HTML #3

Open
andrewsheng2 opened this issue Sep 2, 2021 · 0 comments · May be fixed by #12
Open

Repeated ARIA IDs Used In HTML #3

andrewsheng2 opened this issue Sep 2, 2021 · 0 comments · May be fixed by #12
Assignees
@andrewsheng2
Labels
accessibility
Milestone
HW1

Comments

@andrewsheng2
Copy link
Collaborator

Google Lighthouse gave an Accessibility score of 89 for the Mayan homepage. One of the issues reported is that the ARIA IDs are not unique in the page, which can cause assistive technologies to only announce the first element of an ID instead of all elements.
@andrewsheng2 andrewsheng2 self-assigned this Sep 2, 2021
@andrewsheng2 andrewsheng2 added this to the HW1 milestone Sep 2, 2021
andrewsheng2 added a commit to andrewsheng2/Mayan-EDMS that referenced this issue Sep 3, 2021
@andrewsheng2
Use unique ARIA IDs for tab panel
2a00862 
Fixes CMU-313#3.

In the tab panel, multiple elements were using the same ARIA ID. This
occurs because when elements of the panel get generated, they reuse the
same statically-defined ID. To fix this, replace the ID used with a
dynamically generated one. In this case, use the forloop counter to get
a unique number for each element in the panel, which also reflects the
naming behavior of some other elements in the side panel.
@andrewsheng2 andrewsheng2 linked a pull request Sep 3, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsheng2 andrewsheng2

Labels
accessibility
Projects
None yet
Milestone
HW1
Development

Successfully merging a pull request may close this issue.

Use unique ARIA IDs for tab panel andrewsheng2/Mayan-EDMS
1 participant
@andrewsheng2