Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test result checking #427

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Improve test result checking #427

merged 13 commits into from
Dec 14, 2023

Conversation

bpkroth
Copy link
Collaborator

@bpkroth bpkroth commented Dec 14, 2023

  • Add checks on the result outputs to make sure that the length of time and number of queries expected to run were.
  • Make sure to exit non-zero when RuntimeExceptions are encountered.
  • Temporarily remove a faulty INSERT test from the templated benchmark.

Split out from #283.

@bpkroth bpkroth mentioned this pull request Dec 14, 2023
Open
@bpkroth bpkroth mentioned this pull request Dec 14, 2023
Merged
2 tasks
@bpkroth bpkroth merged commit 5e44cbf into cmu-db:main Dec 14, 2023
124 checks passed
@bpkroth bpkroth deleted the improve-test-result-checking branch December 14, 2023 21:15
bpkroth added a commit that referenced this pull request Dec 14, 2023
@bpkroth
Connection exception and reconnection handling (#283)
2e43289 
Initial work to provide connection error handling that optionally
reconnects.

Fixes #32 

Still probably needs:
- [ ] Unit tests (open to suggestions on how to handle this, but for now
skipping in favor of functional tests in the CI pipeline and local
script infrastructure)
- [x] Expanded/tested support for additional database engines.

Additional work on improving test infrastructure has been split out to
#427.
@bpkroth bpkroth mentioned this pull request Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bpkroth